11:25 a.m.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
Bug #: 2979
Summary: Review request: steam - Installer for the Steam
software distribution service
Classification: Unclassified
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: negativo17(a)gmail.com
CC: rpmfusion-package-review(a)rpmfusion.org
Blocks: 2
Installer for the Steam software distribution service.
Steam is a software distribution service with an online store, automated
installation, automatic updates, achievements, SteamCloud synchronized
savegame and screenshot functionality, and many social features.
Spec URL: http://slaanesh.fedorapeople.org/steam.spec
SRPM URL: http://slaanesh.fedorapeople.org/steam-1.0.0.42-1.fc19.src.rpm
This package cannot be in Fedora as it's not free and comes as a binary package
only. The package is i686 only but installs perfectly fine on an x86_64 system
just using yum. It's in the Fedora RPMFusion wishlist.
$ rpmlint steam.spec
steam.spec:31: W: macro-in-comment %{name}
steam.spec:32: W: macro-in-comment %{_isa}
0 packages and 1 specfiles checked; 0 errors, 2 warnings.
These macro in comments are for the command line required for generating
dependencies on Steam downloaded binaries; it is nice to have them at hand to
check for new dependencies whenever a new Steam client is automatically
downloaded.
$ rpmlint steam-1.0.0.42-1.fc19.i686.rpm
steam.i686: E: explicit-lib-dependency libICE(x86-32)
steam.i686: E: explicit-lib-dependency libSM(x86-32)
steam.i686: E: explicit-lib-dependency libX11(x86-32)
steam.i686: E: explicit-lib-dependency libXau(x86-32)
steam.i686: E: explicit-lib-dependency libXcomposite(x86-32)
steam.i686: E: explicit-lib-dependency libXcursor(x86-32)
steam.i686: E: explicit-lib-dependency libXdamage(x86-32)
steam.i686: E: explicit-lib-dependency libXdmcp(x86-32)
steam.i686: E: explicit-lib-dependency libXext(x86-32)
steam.i686: E: explicit-lib-dependency libXfixes(x86-32)
steam.i686: E: explicit-lib-dependency libXi(x86-32)
steam.i686: E: explicit-lib-dependency libXinerama(x86-32)
steam.i686: E: explicit-lib-dependency libXrandr(x86-32)
steam.i686: E: explicit-lib-dependency libXrender(x86-32)
steam.i686: E: explicit-lib-dependency libXtst(x86-32)
steam.i686: E: explicit-lib-dependency libasyncns(x86-32)
steam.i686: E: explicit-lib-dependency libattr(x86-32)
steam.i686: E: explicit-lib-dependency libcap(x86-32)
steam.i686: E: explicit-lib-dependency libcom_err(x86-32)
steam.i686: E: explicit-lib-dependency libdrm(x86-32)
steam.i686: E: explicit-lib-dependency libffi(x86-32)
steam.i686: E: explicit-lib-dependency libgcc(x86-32)
steam.i686: E: explicit-lib-dependency libgcrypt(x86-32)
steam.i686: E: explicit-lib-dependency libgpg-error(x86-32)
steam.i686: E: explicit-lib-dependency libgudev1(x86-32)
steam.i686: E: explicit-lib-dependency libogg(x86-32)
steam.i686: E: explicit-lib-dependency libpng12(x86-32)
steam.i686: E: explicit-lib-dependency libselinux(x86-32)
steam.i686: E: explicit-lib-dependency libsndfile(x86-32)
steam.i686: E: explicit-lib-dependency libstdc++(x86-32)
steam.i686: E: explicit-lib-dependency libusbx(x86-32)
steam.i686: E: explicit-lib-dependency libuuid(x86-32)
steam.i686: E: explicit-lib-dependency libvorbis(x86-32)
steam.i686: E: explicit-lib-dependency libwayland-client(x86-32)
steam.i686: E: explicit-lib-dependency libwayland-server(x86-32)
steam.i686: E: explicit-lib-dependency libxcb(x86-32)
steam.i686: W: name-repeated-in-summary C steam
steam.i686: W: spelling-error %description -l en_US savegame -> save game,
save-game, pregame
steam.i686: W: spelling-error %description -l en_US screenshot -> screen shot,
screen-shot, screens hot
steam.i686: W: invalid-license Steam License Agreement
steam.i686: E: no-binary
steam.i686: W: only-non-binary-in-usr-lib
steam.i686: W: wrong-file-end-of-line-encoding
/usr/share/doc/steam-1.0.0.42/steam_install_agreement.txt
steam.i686: W: desktopfile-without-binary /usr/share/applications/steam.desktop
/usr/bin/steam
1 packages and 0 specfiles checked; 37 errors, 7 warnings.
Notes on rpmlint on the binary package: the explicit-lib-dependency can be
ignored; these are the dependencies used by the Steam client itself, and need
to be on the system BEFORE the actual Steam client is downloaded. The package
itself contains only a script; so the last errors are related to the fact that
the desktop files etc. point to a script and not a binary.
The package sets STEAM_RUNTIME=0 in /etc/profile.d/steam.*; so the download
client and the Steam client itself do NOT use Ubuntu libraries (the Steam
runtime) for running; but instead use the Fedora system provided ones.
For additional details on the setup please see here:
http://negativo17.org/steam/
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
12:19 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
Richard <hobbes1069(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hobbes1069(a)gmail.com
--- Comment #1 from Richard <hobbes1069(a)gmail.com> 2013-10-03 14:19:08 CEST ---
Looks promising... Once in RPM Fusion you won't need the Requires: for the RPM
Fusion repos since this will have to go in non-free the user will already have
them installed.
What's the redistributable status for this? It was intended for Ubuntu, right?
So I think the only question is do they allow for modification for Fedora?
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
12:27 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #2 from Simone Caronni <negativo17(a)gmail.com> 2013-10-03 14:27:02 CEST
---
A(In reply to comment #1)
Looks promising... Once in RPM Fusion you won't need the
Requires: for the RPM
Fusion repos since this will have to go in non-free the user will already have
them installed.
Yep, you're right. Removed them:
What's the redistributable status for this? It was intended for
Ubuntu, right?
So I think the only question is do they allow for modification for Fedora?
This can be redistributed (contrary to my other Skype review... sigh). Original
announcement here:
http://steamcommunity.com/groups/SteamClientBeta#announcements/detail/174...
And directly from the license file inside the package there are notes on Linux
repackaging:
"LICENSE AGREEMENT
1. Grant of Licenses.
A. Personal Use Limited Installation License. Valve hereby grants, and
by installing the Program you thereby accept, a limited, non-exclusive license
and right to install copies of the Program on each of your computers solely for
your personal use.
B. Limited Redistribution License. Valve hereby grants, and you accept,
a limited, terminable, non-exclusive license to reproduce and distribute an
unlimited number of copies of the Program; provided that the following
conditions are met:
(i) you must distribute the Program in its entirety;
(ii) you may not modify the Program, except that, in the case of the
Linux version of the Program, you may modify scripts and other documentary and
graphical files, but not any files containing the term “bootstrap” in the file
name, provided that you do not modify any icons, change any copyright or other
notices, or alter this or any other license agreement that is included with the
Program, and provided further that any modifications you make are identified by
you as modifications from the original Program provided by Valve;
(iii) you may repackage the Program and distribute it with another
software program, provided that you do not integrate the Program in any way
with that other software program, or combine the Program with that other
software program in a manner that would require you to distribute the Program
under any open source or other license terms different from these terms.
(iv) you may not charge any separate fee or receive any compensation
attributable to the Program;
(v) you must include this License Agreement provided with the Program
and ensure that it will display and be required to be accepted by the end user
in the same manner as is required by the Program in the form received by you;
and
(vi) you must preserve in all copies of the Program all copyright and
legal notices that are attached to the copy of the Program received by you."
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
12:29 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #3 from Simone Caronni <negativo17(a)gmail.com> 2013-10-03 14:29:00 CEST
---
Update with removal of dependency on the repositories (it was for my
repository..):
Spec URL: http://slaanesh.fedorapeople.org/steam.spec
SRPM URL: http://slaanesh.fedorapeople.org/steam-1.0.0.42-2.fc19.src.rpm
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
5:28 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #4 from Simone Caronni <negativo17(a)gmail.com> 2013-10-09 19:28:03 CEST
---
Spec URL: http://slaanesh.fedorapeople.org/steam.spec
SRPM URL: http://slaanesh.fedorapeople.org/steam-1.0.0.43-1.fc19.src.rpm
Updated to 1.0.0.43. Oculus Rift support has been added to the udev rules!
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:11 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
leigh scott <leigh123linux(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |leigh123linux(a)gmail.com
--- Comment #5 from leigh scott <leigh123linux(a)gmail.com> 2013-10-10 15:11:31 CEST
---
You can remove a lot of the requires as other packages bring them in i.e gtk2
$ repoquery --requires gtk2.i686
/bin/sh
atk >= 1.29.4-2
glib2 >= 2.28.0-1
hicolor-icon-theme
libX11.so.6
libXcomposite.so.1
libXcursor.so.1
libXdamage.so.1
libXext.so.6
libXfixes.so.3
libXi.so.6
libXinerama.so.1
libXrandr >= 1.2.99.4-2
libXrandr.so.2
libXrender.so.1
libatk-1.0.so.0
libc.so.6(GLIBC_2.4)
libcairo.so.2
libcups.so.2
libfontconfig.so.1
libfreetype.so.6
libgdk_pixbuf-2.0.so.0
libgio-2.0.so.0
libglib-2.0.so.0
libgmodule-2.0.so.0
libgobject-2.0.so.0
libm.so.6
libm.so.6(GLIBC_2.0)
libm.so.6(GLIBC_2.1)
libpango-1.0.so.0
libpangocairo-1.0.so.0
libpangoft2-1.0.so.0
libpthread.so.0
libpthread.so.0(GLIBC_2.0)
libpthread.so.0(GLIBC_2.2)
libtiff >= 3.6.1
pango >= 1.20.0-1
rtld(GNU_HASH)
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:17 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #6 from Richard <hobbes1069(a)gmail.com> 2013-10-10 15:17:58 CEST ---
Leigh, do you want to take this one?
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:21 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #7 from Simone Caronni <negativo17(a)gmail.com> 2013-10-10 15:21:31 CEST
---
(In reply to comment #5)
You can remove a lot of the requires as other packages bring them in
i.e gtk2
Here is the one with the dependencies of Gtk removed. I wanted to have
something easily reproducible for new Steam client releases but I think it's ok
as well with a minimum screening of the list of requirements done by hand.
I've updated the comment in the spec file as well.
Spec URL: http://slaanesh.fedorapeople.org/steam.spec
SRPM URL: http://slaanesh.fedorapeople.org/steam-1.0.0.43-2.fc19.src.rpm
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:22 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #8 from Simone Caronni <negativo17(a)gmail.com> 2013-10-10 15:22:15 CEST
---
(In reply to comment #7)
Here is the one with the dependencies of Gtk removed. I wanted to
have
something easily reproducible for new Steam client releases but I think it's ok
as well with a minimum screening of the list of requirements done by hand.
If you spot any other dependency that could be removed please let me know.
Thanks.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:25 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
Edward Rudd <urkle(a)outoforder.cc> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |urkle(a)outoforder.cc
--- Comment #9 from Edward Rudd <urkle(a)outoforder.cc> 2013-10-10 15:25:30 CEST ---
Because of valves "steam runtime", you can actually remove nearly ALL of the
dependencies as steam downloads and sets up a private directory with all of the
deps. IMHO I would like to see two packages.. steam and steam-noruntime.
the later having all of the dependencies attached to it and having a wrapper
script that launches steam like this
STEAM_RUNTIME=0 steam
This will cause steam to NOT enable the runtime and thus games and steam will
simply use the OS dependencies.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:30 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #10 from Simone Caronni <negativo17(a)gmail.com> 2013-10-10 15:30:21 CEST
---
(In reply to comment #9)
Because of valves "steam runtime", you can actually remove
nearly ALL of the
dependencies as steam downloads and sets up a private directory with all of the
deps. IMHO I would like to see two packages.. steam and steam-noruntime.
I think this will create more confusion for the users. The source file in
/etc/profile.d/ is marked as config file, so it's up to the user to change it
(if they want).
In my opinion what we should do is to ship a package that is as close as
possible to the Fedora guidelines; so the package should try to use only system
libraries and resort to the steam runtime only as a last resort.
Btw, I've run it with the runtime disabled since the first releases and I did
not have any issues, there was only one time where I needed to add libusb and
NetowrkManager libraries. The steam runtime on my system can get up to 250mb.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:41 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #11 from Edward Rudd <urkle(a)outoforder.cc> 2013-10-10 15:41:49 CEST ---
:).. yeah.. I just don't like the steam runtime at all. it's going to cause
issues in future linux distributions as it includes too much stuff. I've had a
number of games I've published up on steam have audio breakage because of the
runtime. (I've pushed, oh, around 15 linux games up on steam I think?).
So, is this package going to default the runtime off?
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:44 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #12 from Simone Caronni <negativo17(a)gmail.com> 2013-10-10 15:44:42 CEST
---
(In reply to comment #11)
:).. yeah.. I just don't like the steam runtime at all. it's
going to cause
issues in future linux distributions as it includes too much stuff. I've had a
number of games I've published up on steam have audio breakage because of the
runtime. (I've pushed, oh, around 15 linux games up on steam I think?).
Cool, which games? Have a list?
So, is this package going to default the runtime off?
Yes please, I would like so. I think it's cleaner, better and smaller.
I have nearly ~100 games; I can post the list here. All of them work without
the Ubuntu runtime.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:45 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #13 from Simone Caronni <negativo17(a)gmail.com> 2013-10-10 15:45:23 CEST
---
I'm removing additional requirements that are pulled in by other components
(mesa, nss, ssl, etc.).
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:57 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #14 from Simone Caronni <negativo17(a)gmail.com> 2013-10-10 15:57:09 CEST
---
(In reply to comment #13)
I'm removing additional requirements that are pulled in by other
components
(mesa, nss, ssl, etc.).
I've cleaned them all to the minimum requirement and adjusted comments. Please
note that the release of the package is the same (1.0.0.43-2.fc19) so the last
link is ok.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:09 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #15 from leigh scott <leigh123linux(a)gmail.com> 2013-10-10 16:09:37 CEST
---
(In reply to comment #7)
(In reply to comment #5)
> You can remove a lot of the requires as other packages bring them in i.e gtk2
Here is the one with the dependencies of Gtk removed. I wanted to have
something easily reproducible for new Steam client releases but I think it's ok
as well with a minimum screening of the list of requirements done by hand.
I've updated the comment in the spec file as well.
Spec URL: http://slaanesh.fedorapeople.org/steam.spec
SRPM URL: http://slaanesh.fedorapeople.org/steam-1.0.0.43-2.fc19.src.rpm
You missed loads
http://pastebin.com/raw.php?i=YRL54Gc0
mesa also satisfy a lot of deps
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:11 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #16 from Simone Caronni <negativo17(a)gmail.com> 2013-10-10 16:11:26 CEST
---
(In reply to comment #15)
You missed loads
http://pastebin.com/raw.php?i=YRL54Gc0
mesa also satisfy a lot of deps
Yes, I've already done it (see comment #14).
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:36 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #17 from Simone Caronni <negativo17(a)gmail.com> 2013-10-10 16:36:25 CEST
---
(In reply to comment #12)
(In reply to comment #11)
> :).. yeah.. I just don't like the steam runtime at all. it's going to
cause
> issues in future linux distributions as it includes too much stuff. I've had a
> number of games I've published up on steam have audio breakage because of the
> runtime. (I've pushed, oh, around 15 linux games up on steam I think?).
Cool, which games? Have a list?
Totally off topic: if this is you
http://pcgamingwiki.com/wiki/Developer:Edward_Rudd
I've got most of the games you've worked on, the majority of them through
Humble bundles and Uplink even on a printed CD (iirc).
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:56 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #18 from Edward Rudd <urkle(a)outoforder.cc> 2013-10-10 16:56:36 CEST ---
(In reply to comment #17)
Totally off topic: if this is you
http://pcgamingwiki.com/wiki/Developer:Edward_Rudd
I've got most of the games you've worked on, the majority of them through
Humble bundles and Uplink even on a printed CD (iirc).
Yes, that is me.. now the Introversion games I only did a "refresh" of the
ports (64bit support and updated for more modern linux distros). And that is
a fairly complete list.. I'll have to update with things that are missing:)
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:55 a.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #19 from Simone Caronni <negativo17(a)gmail.com> 2013-10-14 09:55:27 CEST
---
Hello, there are a few discussions around regarding Spot's repository; it's
currently broken and not updated anymore but it's still the default suggestion
from Valve's forums.
Any chance to see this review proceeding for a more "official" inclusion?
Thanks & regards,
--Simone
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:35 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #20 from Simone Caronni <negativo17(a)gmail.com> 2013-10-20 20:35:07 CEST
---
Spec URL: http://slaanesh.fedorapeople.org/steam.spec
SRPM URL: http://slaanesh.fedorapeople.org/steam-1.0.0.43-3.fc19.src.rpm
Add missing libappindicator requirement.
It is required for the tray icon but is not linked to any binary so it's not
spotted by the recursive ldd.
Error spotted on the Steam Community forum.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:09 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
MartinKG <mgansser(a)alice.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mgansser(a)alice.de
--- Comment #21 from MartinKG <mgansser(a)alice.de> 2013-10-22 16:09:41 CEST ---
a review of steam displays the following messages
fedora-review -m fedora-rawhide-i386-rpmfusion_nonfree -n steam
error: File must begin with "/":
%{_udevrulesdir}/99-steam-controller-perms.rules
Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.peiWJK
+ umask 022
+ cd /builddir/build/BUILD
+ cd steam
+
DOCDIR=/builddir/build/BUILDROOT/steam-1.0.0.43-3.fc21.i386/usr/share/doc/steam
+ export DOCDIR
+ /usr/bin/mkdir -p
/builddir/build/BUILDROOT/steam-1.0.0.43-3.fc21.i386/usr/share/doc/steam
+ cp -pr README
/builddir/build/BUILDROOT/steam-1.0.0.43-3.fc21.i386/usr/share/doc/steam
+ cp -pr COPYING
/builddir/build/BUILDROOT/steam-1.0.0.43-3.fc21.i386/usr/share/doc/steam
+ cp -pr steam_install_agreement.txt
/builddir/build/BUILDROOT/steam-1.0.0.43-3.fc21.i386/usr/share/doc/steam
+ cp -pr debian/changelog
/builddir/build/BUILDROOT/steam-1.0.0.43-3.fc21.i386/usr/share/doc/steam
+ cp -pr README.Fedora
/builddir/build/BUILDROOT/steam-1.0.0.43-3.fc21.i386/usr/share/doc/steam
+ exit 0
RPM build errors:
File must begin with "/": %{_udevrulesdir}/99-steam-controller-perms.rules
Child return code was: 1
EXCEPTION: Command failed. See logs for output.
# ['bash', '--login', '-c', 'rpmbuild -bb --target i686
--nodeps
builddir/build/SPECS/steam.spec']
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line
70, in trace
result = func(*args, **kw)
File "/usr/lib/python2.7/site-packages/mockbuild/util.py", line 361, in do
raise mockbuild.exception.Error, ("Command failed. See logs for output.\n #
%s" % (command,), child.returncode)
Error: Command failed. See logs for output.
# ['bash', '--login', '-c', 'rpmbuild -bb --target i686
--nodeps
builddir/build/SPECS/steam.spec']
LEAVE do --> EXCEPTION RAISED
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:17 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #22 from leigh scott <leigh123linux(a)gmail.com> 2013-10-22 16:17:51 CEST
---
(In reply to comment #21)
a review of steam displays the following messages
fedora-review -m fedora-rawhide-i386-rpmfusion_nonfree -n steam
error: File must begin with "/":
%{_udevrulesdir}/99-steam-controller-perms.rules
Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.peiWJK
+ umask 022
+ cd /builddir/build/BUILD
+ cd steam
+
DOCDIR=/builddir/build/BUILDROOT/steam-1.0.0.43-3.fc21.i386/usr/share/doc/steam
+ export DOCDIR
+ /usr/bin/mkdir -p
/builddir/build/BUILDROOT/steam-1.0.0.43-3.fc21.i386/usr/share/doc/steam
+ cp -pr README
/builddir/build/BUILDROOT/steam-1.0.0.43-3.fc21.i386/usr/share/doc/steam
+ cp -pr COPYING
/builddir/build/BUILDROOT/steam-1.0.0.43-3.fc21.i386/usr/share/doc/steam
+ cp -pr steam_install_agreement.txt
/builddir/build/BUILDROOT/steam-1.0.0.43-3.fc21.i386/usr/share/doc/steam
+ cp -pr debian/changelog
/builddir/build/BUILDROOT/steam-1.0.0.43-3.fc21.i386/usr/share/doc/steam
+ cp -pr README.Fedora
/builddir/build/BUILDROOT/steam-1.0.0.43-3.fc21.i386/usr/share/doc/steam
+ exit 0
RPM build errors:
File must begin with "/": %{_udevrulesdir}/99-steam-controller-perms.rules
Child return code was: 1
EXCEPTION: Command failed. See logs for output.
# ['bash', '--login', '-c', 'rpmbuild -bb --target i686
--nodeps
builddir/build/SPECS/steam.spec']
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line
70, in trace
result = func(*args, **kw)
File "/usr/lib/python2.7/site-packages/mockbuild/util.py", line 361, in do
raise mockbuild.exception.Error, ("Command failed. See logs for output.\n #
%s" % (command,), child.returncode)
Error: Command failed. See logs for output.
# ['bash', '--login', '-c', 'rpmbuild -bb --target i686
--nodeps
builddir/build/SPECS/steam.spec']
LEAVE do --> EXCEPTION RAISED
It needs BuildRequires: systemd adding to the spec file.
rpm -qf /usr/lib/rpm/macros.d/macros.systemd
systemd-208-2.fc20.x86_64
As you can see systemd provides the macro for %{_udevrulesdir}
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:26 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #23 from Simone Caronni <negativo17(a)gmail.com> 2013-10-22 16:26:01 CEST
---
Spec URL: http://slaanesh.fedorapeople.org/steam.spec
SRPM URL: http://slaanesh.fedorapeople.org/steam-1.0.0.43-4.fc19.src.rpm
- Added build requirements on systemd for udev rules.
(In reply to comment #21)
a review of steam displays the following messages
fedora-review -m fedora-rawhide-i386-rpmfusion_nonfree -n steam
Quick question: I don't see the usual fedora-review/cvs flags in RPMFusion's
bugzilla. This means MartinKG is taking the review?
Thanks & regards,
--Simone
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:28 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
Andrea Musuruane <musuruan(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |musuruan(a)gmail.com
--- Comment #24 from Andrea Musuruane <musuruan(a)gmail.com> 2013-10-22 16:28:06 CEST
---
(In reply to comment #23)
Quick question: I don't see the usual fedora-review/cvs flags in
RPMFusion's
bugzilla. This means MartinKG is taking the review?
No. To take the review, reviewer should assign the review to himself, remove
the block from #2, and block #3:
http://rpmfusion.org/Contributors#Wait_for_your_package_to_be_reviewed
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:30 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #25 from Simone Caronni <negativo17(a)gmail.com> 2013-10-22 16:30:39 CEST
---
(In reply to comment #24)
No. To take the review, reviewer should assign the review to himself,
remove
the block from #2, and block #3:
http://rpmfusion.org/Contributors#Wait_for_your_package_to_be_reviewed
Thanks for the info. Was still at point 3.2. :D
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:09 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #26 from MartinKG <mgansser(a)alice.de> 2013-10-22 20:09:59 CEST ---
remove 'rm -rf %{buildroot}' from %install section, it's not longer required.
http://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25install_sec...
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:32 a.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #27 from MartinKG <mgansser(a)alice.de> 2013-10-23 08:32:09 CEST ---
package steam contains desktop file(s) with a MimeType: entry.
please update-desktop-database in spec file
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database
%post
/usr/bin/update-mime-database %{_datadir}/mime &> /dev/null || :
%postun
/usr/bin/update-mime-database %{_datadir}/mime &> /dev/null || :
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:57 a.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #28 from Simone Caronni <negativo17(a)gmail.com> 2013-10-23 09:57:37 CEST
---
(In reply to comment #27)
package steam contains desktop file(s) with a MimeType: entry.
please update-desktop-database in spec file
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database
Done.
%post
/usr/bin/update-mime-database %{_datadir}/mime &> /dev/null || :
%postun
/usr/bin/update-mime-database %{_datadir}/mime &> /dev/null || :
Please note that this is for mimeinfo
(http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo) and not
for desktop-database, probably a copy & paste error.
Spec URL: http://slaanesh.fedorapeople.org/steam.spec
SRPM URL: http://slaanesh.fedorapeople.org/steam-1.0.0.43-5.fc19.src.rpm
- Added desktop-database commands in %post/%postun
- Removed removal of buildroot in %install
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:03 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
Simone Caronni <negativo17(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|2 |3
AssignedTo|rpmfusion-package-review@rp |leamas.alec(a)gmail.com
|mfusion.org |
--- Comment #29 from Simone Caronni <negativo17(a)gmail.com> 2013-10-23 15:03:33 CEST
---
Issues:
[!]: Useful -debuginfo package or justification otherwise.
Disabling debuginfo is fine here, but needs a justification comment.
[!]: Requires correct, justified where necessary.
[!]: Package must own all directories that it creates.
/usr/lib/udev and /usr/lib/udev/rules.d are owned by systemd,
/etc/profile.d by setup. These need to be Require:'d.
[!]: Package contains no bundled libraries without FPC exception.
The bundled libraries need to be in package according to the license.
Still, they need a bundling exception. Request on rpmfusion-developers.
[!]: Valid rpmlint warnings, please fix:
name-repeated-in-summary C Steam
wrong-file-end-of-line-encoding
/usr/share/doc/steam/steam_install_agreement.txt
steam.src:35: W: macro-in-comment %{name}
steam.src:36: W: macro-in-comment %{_isa}
[!]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
-->OK for rpmfusion, though. Please add some kind of reference to
the license in a comment above it.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:05 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
Simone Caronni <negativo17(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #30 from Simone Caronni <negativo17(a)gmail.com> 2013-10-23 15:05:11 CEST
---
Changed assignee on behalf of Alec Leamas. He's currently unable to login; it's
waiting on a password reset.
He requested to me to become the assignee in a private mail; as soon as his
password is reset he will proceed.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
1:27 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #31 from Simone Caronni <negativo17(a)gmail.com> 2013-10-23 15:27:17 CEST
---
(In reply to comment #29)
Issues:
[!]: Useful -debuginfo package or justification otherwise.
Disabling debuginfo is fine here, but needs a justification comment.
Added comment.
[!]: Requires correct, justified where necessary.
[!]: Package must own all directories that it creates.
/usr/lib/udev and /usr/lib/udev/rules.d are owned by systemd,
/etc/profile.d by setup. These need to be Require:'d.
I've added them as BuildRequirements so I can avoid the "mkdir -p"
commands;
the folder is already available at build time and I can just copy the files
into them.
Adding them as Requirement is not required as setup and systemd are already
pulled in by other packages.
wrong-file-end-of-line-encoding
/usr/share/doc/steam/steam_install_agreement.txt
Done, did as packaging guidelines suggested and removed dos2unix
(https://fedoraproject.org/wiki/Common_Rpmlint_issues#wrong-file-end-of-li...).
steam.src:35: W: macro-in-comment %{name}
steam.src:36: W: macro-in-comment %{_isa}
Fixed, escaped them (%%).
[!]: Package is licensed with an open-source compatible license and
meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
-->OK for rpmfusion, though. Please add some kind of reference to
the license in a comment above it.
Done, added a comment.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
1:31 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #32 from Simone Caronni <negativo17(a)gmail.com> 2013-10-23 15:31:58 CEST
---
Spec URL: http://slaanesh.fedorapeople.org/steam.spec
SRPM URL: http://slaanesh.fedorapeople.org/steam-1.0.0.43-6.fc19.src.rpm
Added all changes except this:
[!]: Valid rpmlint warnings, please fix:
name-repeated-in-summary C Steam
I've taken the description from their official deb package, I think it's pretty
good. Any idea on how can I remove the Steam word if the word "SteamCloud"
stays there? Also "Steam software distribution service" IMHO should remain as
is. Ideas?
(personally I think this rpmlint check is quite stupid, it causes more
confusing description than anything else)
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
1:38 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #33 from Simone Caronni <negativo17(a)gmail.com> 2013-10-23 15:38:43 CEST
---
(In reply to comment #31)
> [!]: Requires correct, justified where necessary.
> [!]: Package must own all directories that it creates.
> /usr/lib/udev and /usr/lib/udev/rules.d are owned by systemd,
> /etc/profile.d by setup. These need to be Require:'d.
I've added them as BuildRequirements so I can avoid the "mkdir -p"
commands;
the folder is already available at build time and I can just copy the files
into them.
Adding them as Requirement is not required as setup and systemd are already
pulled in by other packages.
I've reverted this, first of all it doesn't work, systemd is required by some
of the other packages listed as prerequisites and setup is required by
basesystem.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
2:02 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #34 from Simone Caronni <negativo17(a)gmail.com> 2013-10-23 16:02:13 CEST
---
Alec Leamas wrote:
"Looks fine. Two more issues:
- In the README.fedora you refer to
http://slaanesh.fedorapeople.org/flash-plugin/README.txt. This doesn't seemt to
exist.
- You run %{_bindir}/update-desktop-database &> /dev/null || : only if [ $1 -eq 0
]. This is not as proposed in the standard packaging scriptlets where it's run
unconditionally [1]. Please fix or justify current code.
[1] http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database
We continue as "normal": : you paste the remarks in the bug....
While you're on it: if other packages pulls systemd, why list systemd-libs?
Thanks, adjusted them all. Systemd-libs is pulled in by mesa and a lot of other
things.
Still at revision 6:
Spec URL: http://slaanesh.fedorapeople.org/steam.spec
SRPM URL: http://slaanesh.fedorapeople.org/steam-1.0.0.43-6.fc19.src.rpm
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
7:34 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #35 from Alec Leamas <leamas.alec(a)gmail.com> 2013-10-23 21:34:33 CEST
---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
===== MUST items =====
Issues:
- Nicholas suggests using ExclusiveArch: i686, lets stick to that.
Generic:
[!]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
--> OK for rpmfusion.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 1 files have unknown license. Detailed output of
licensecheck in /home/mk/FedoraReview/2979-steam/licensecheck.txt
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/udev, /etc/profile.d,
/usr/lib/udev/rules.d
[-]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: update-desktop-database is invoked in %post and %postun if package
contains desktop file(s) with a MimeType: entry.
Note: desktop file(s) with MimeType entry in steam
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in steam
[x]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
Well, it does, it's correct and that's how it is.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: steam-1.0.0.43-6.fc21.i686.rpm
steam-1.0.0.43-6.fc21.src.rpm
steam.i686: E: explicit-lib-dependency libXau(x86-32)
steam.i686: E: explicit-lib-dependency libXdmcp(x86-32)
steam.i686: E: explicit-lib-dependency libappindicator(x86-32)
steam.i686: E: explicit-lib-dependency libasyncns(x86-32)
steam.i686: E: explicit-lib-dependency libattr(x86-32)
steam.i686: E: explicit-lib-dependency libffi(x86-32)
steam.i686: E: explicit-lib-dependency libpng12(x86-32)
steam.i686: E: explicit-lib-dependency libsndfile(x86-32)
steam.i686: E: explicit-lib-dependency libtxc_dxtn(x86-32)
steam.i686: E: explicit-lib-dependency libusbx(x86-32)
steam.i686: W: name-repeated-in-summary C Steam
steam.i686: W: spelling-error %description -l en_US savegame -> save game,
save-game, pregame
steam.i686: W: spelling-error %description -l en_US screenshot -> screen shot,
screen-shot, screens hot
steam.i686: W: invalid-license Steam License Agreement
steam.i686: E: no-binary
steam.i686: W: only-non-binary-in-usr-lib
steam.i686: W: desktopfile-without-binary /usr/share/applications/steam.desktop
/usr/bin/steam
steam.src: W: name-repeated-in-summary C Steam
steam.src: W: spelling-error %description -l en_US savegame -> save game,
save-game, pregame
steam.src: W: spelling-error %description -l en_US screenshot -> screen shot,
screen-shot, screens hot
steam.src: W: invalid-license Steam License Agreement
2 packages and 0 specfiles checked; 11 errors, 10 warnings.
Rpmlint (installed packages)
----------------------------
# rpmlint steam
steam.i686: E: explicit-lib-dependency libXau(x86-32)
steam.i686: E: explicit-lib-dependency libXdmcp(x86-32)
steam.i686: E: explicit-lib-dependency libappindicator(x86-32)
steam.i686: E: explicit-lib-dependency libasyncns(x86-32)
steam.i686: E: explicit-lib-dependency libattr(x86-32)
steam.i686: E: explicit-lib-dependency libffi(x86-32)
steam.i686: E: explicit-lib-dependency libpng12(x86-32)
steam.i686: E: explicit-lib-dependency libsndfile(x86-32)
steam.i686: E: explicit-lib-dependency libtxc_dxtn(x86-32)
steam.i686: E: explicit-lib-dependency libusbx(x86-32)
steam.i686: W: name-repeated-in-summary C Steam
steam.i686: W: spelling-error %description -l en_US savegame -> save game,
save-game, pregame
steam.i686: W: spelling-error %description -l en_US screenshot -> screen shot,
screen-shot, screens hot
steam.i686: W: invalid-license Steam License Agreement
steam.i686: E: no-binary
steam.i686: W: only-non-binary-in-usr-lib
1 packages and 0 specfiles checked; 11 errors, 5 warnings.
# echo 'rpmlint-done:'
Requires
--------
steam (rpmlib, GLIBC filtered):
/bin/sh
/usr/bin/env
NetworkManager-glib(x86-32)
SDL2(x86-32)
alsa-lib(x86-32)
alsa-plugins-pulseaudio(x86-32)
avahi-libs(x86-32)
config(steam)
expat(x86-32)
gtk2(x86-32)
harfbuzz(x86-32)
json-c(x86-32)
keyutils-libs(x86-32)
libXau(x86-32)
libXdmcp(x86-32)
libappindicator(x86-32)
libasyncns(x86-32)
libattr(x86-32)
libffi(x86-32)
libpng12(x86-32)
libsndfile(x86-32)
libtxc_dxtn(x86-32)
libusbx(x86-32)
mesa-libEGL(x86-32)
mesa-libGL(x86-32)
mesa-libgbm(x86-32)
nss(x86-32)
openal-soft(x86-32)
openssl-libs(x86-32)
pcre(x86-32)
pixman(x86-32)
pulseaudio-libs(x86-32)
tar
tcp_wrappers-libs(x86-32)
zenity
Provides
--------
steam:
application()
application(steam.desktop)
config(steam)
mimehandler(x-scheme-handler/steam)
steam
steam(x86-32)
Source checksums
----------------
http://repo.steampowered.com/steam/pool/steam/s/steam/steam_1.0.0.43.tar.gz :
CHECKSUM(SHA256) this package :
7c22d08944183c6b0fe5c62e6ba71beece8fe11146e3a15e9ee8bcddebb7bc8f
CHECKSUM(SHA256) upstream package :
7c22d08944183c6b0fe5c62e6ba71beece8fe11146e3a15e9ee8bcddebb7bc8f
Generated by fedora-review 0.5.0 (928f2b2) last change: 2013-10-14
Command line :./try-fedora-review -m fedora-rawhide-i386-rpmfusion_nonfree
--other-bz=https://bugzilla.rpmfusion.org/ -b 2979
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl,
Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
7:36 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
Alec Leamas <leamas.alec(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |4
--- Comment #36 from Alec Leamas <leamas.alec(a)gmail.com> 2013-10-23 21:36:03 CEST
---
Package looks good (fix the ExclusiveArch, though)
*** APPROVED
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
7:36 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
Alec Leamas <leamas.alec(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|3 |4
Depends on|4 |
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
7:38 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #37 from Simone Caronni <negativo17(a)gmail.com> 2013-10-23 21:38:55 CEST
---
Latest comments, just for reference...
On 23 October 2013 20:06, Alec Leamas wrote:
Besides that, this discussion draws my attention to all these %{_isa}
suffixes
in the explicit deps. It doesn't really makes sense IMHO. %_isa is the way to
dynamically refer to the architecture. However, these are all 32-bit deps,
which means that %_isa can't be anything but (x86-32). Now, if we always build
on a 32-bit host the net result is the same. But needlessly complicated, and I
wonder if not an explicit '(x86-32)' is a better option in this case?
Creating a 64 bit package, with all libraries and programs written in as
library(x86-32) in the requirements is really ugly.
After installing the Steam client, there are "hints" (libraries, a stub Ubuntu
runtime, etc.) that the client will sooner or later ported to 64 bit; so
creating a package like that would create a lot of mess. Example:
$ ls -ald ubuntu12_*
drwx------. 2 slaanesh slaanesh 4096 Oct 20 19:57 ubuntu12_32
drwxrwxr-x. 2 slaanesh slaanesh 4096 Oct 10 23:37 ubuntu12_64
$ ls -al ubuntu12_64/
total 15460
drwxrwxr-x. 2 slaanesh slaanesh 4096 Oct 10 23:37 .
drwx------. 26 slaanesh slaanesh 4096 Oct 23 16:37 ..
-rwxrwxr-x. 1 slaanesh slaanesh 472576 Oct 4 02:47 crashhandler.so
-rwxrwxr-x. 1 slaanesh slaanesh 173323 Sep 27 19:57 gameoverlayrenderer.so
-rwxrwxr-x. 1 slaanesh slaanesh 191997 Sep 25 23:57 libtier0_s.so
-rwxrwxr-x. 1 slaanesh slaanesh 235937 Oct 4 02:47 libvstdlib_s.so
-rwxrwxr-x. 1 slaanesh slaanesh 14739300 Oct 9 04:25 steamclient.so
$ ldd ubuntu12_64/steamclient.so
linux-vdso.so.1 => (0x00007fff6673c000)
[...]
libstdc++.so.6 => /lib64/libstdc++.so.6 (0x00007f1d8cbb3000)
libpthread.so.0 => /lib64/libpthread.so.0 (0x00007f1d8c997000)
/lib64/ld-linux-x86-64.so.2 (0x00000034b0600000)
libc.so.6 => /lib64/libc.so.6 (0x00007f1d8c5d5000)
[...]
So a guess is that a 64 bit Steam client will be probably released (maybe on
the new Steam machines already?) and leaving %_isa should allow you to rebuild
the package easily for x86_64 simply by adding it to the ExclusiveArch tag.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
7:46 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #38 from Simone Caronni <negativo17(a)gmail.com> 2013-10-23 21:46:39 CEST
---
Thanks for the review!
One question about ExclusiveArch; %{ix86} already contains i686 and if (ever)
Fedora would switch to i786 or anything like that it would be included as well.
$ rpm --eval %{ix86}
i386 i486 i586 i686 pentium3 pentium4 athlon geode
I think Nicolas in the mail was referring more generically to the architecture
rather than the specific variant.
Asking on the mailing list.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
8:01 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #39 from Simone Caronni <negativo17(a)gmail.com> 2013-10-23 22:01:16 CEST
---
(In reply to comment #38)
Asking on the mailing list.
Ok, answer arrived, changing to i686 in the spec file.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
6:49 a.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
Simone Caronni <negativo17(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|4 |33
--- Comment #40 from Simone Caronni <negativo17(a)gmail.com> 2013-10-24 08:49:29 CEST
---
Package CVS request
======================
Package Name: steam
Short Description: Installer for the Steam software distribution service
Owners: slaanesh
Branches: f18 f19 f20
InitialCC:
----------------------
License tag: nonfree
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
9:57 a.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
Nicolas Chauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|33 |
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
9:08 p.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
Simone Caronni <negativo17(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #41 from Simone Caronni <negativo17(a)gmail.com> 2013-10-28 22:08:27 CET
---
Built succesfully on Fedora 18+.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
11:04 a.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
Patric Schramm <patric.schramm(a)rub.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |patric.schramm(a)rub.de
--- Comment #42 from Patric Schramm <patric.schramm(a)rub.de> 2013-11-03 12:04:38 CET
---
Tried the package on a F19 64-Bit system. The packaage installed without
problems, but when i start steam i get an error that my graphics system is
lacking open-GL capabilities.
After some debugging i noticed that mesa-dri-drivers i686 package was not
pulled as dependency. This needs to be fixed.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
8:47 a.m.
New subject: [Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #43 from Simone Caronni <negativo17(a)gmail.com> 2013-11-04 09:47:11 CET
---
(In reply to comment #42)
After some debugging i noticed that mesa-dri-drivers i686 package was
not
pulled as dependency. This needs to be fixed.
Indeed, it is required. Issuing an update now. Please note that this is the
review tracker and you should create a new ticket for reporting issues.
Thanks.
--Simone
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
3825
days inactive
3857
days old
rpmfusion-developers@lists.rpmfusion.org
45 comments
1 participants
participants (1)
-
RPM Fusion Bugzilla