http://bugzilla.rpmfusion.org/show_bug.cgi?id=1321 --- Comment #1 from NicolasChauvet <kwizart(a)gmail.com&gt; 2010-07-05 17:58:16 --- This is the Fedora's review: https://bugzilla.redhat.com/show_bug.cgi?id=518546 -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1321 --- Comment #2 from Adam Williamson <adamwill(a)shaw.ca&gt; 2010-07-05 19:29:30 --- as the guy who packages libva in my video-experimental repo when I can be bothered to, and owns the Fedora package review, I heartily endorse this product and/or service. I don't mind at all if Nicolas owns the package for Fusion. Feel free to make me a co-maintainer, and I will likely be far too lazy ever to do anything with it. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1321 NicolasChauvet <kwizart(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2 -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1321 Hans de Goede <j.w.r.degoede(a)hhs.nl&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #5 from Hans de Goede <j.w.r.degoede(a)hhs.nl&gt; 2010-07-12 13:43:24 --- Hi, A few small remarks / questions / things to fix 1) Can we please rename the *package* to libva-freeworld, so that if / when parts of libva show up in Fedora, it can be named libva there, and we can include only some non free plugins (or so I hope) and drop the rest, Requiring the new libva to ensure a smooth upgrade path. 2) I don't like the chosen versioning scheme, I would prefer Version: 0.31.0 Release: 1.sds13%{?dist} Which also seems to be more conform the guidelines: http://fedoraproject.org/wiki/PackageNamingGuidelines#Non-Numeric_Version... and you can then drop the %sver global, and the -n argument to %setup 3) this line: %doc COPYING Is present in all 3 %files section, as all sub-packages implicitly or explicitly require the main package this should only be present in the main %files Thanks & Regards, Hans -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1321 --- Comment #7 from Hans de Goede <j.w.r.degoede(a)hhs.nl&gt; 2010-07-16 11:38:19 --- Good: - rpmlint checks return: libva-freeworld.x86_64: W: self-obsoletion libva < 0.31.0.1.sds130 obsoletes libva = 1:0.31.0-1.sds13.fc13 libva-freeworld.x86_64: W: no-manual-page-for-binary vainfo libva-freeworld-devel.x86_64: W: self-obsoletion libva-devel < 0.31.0.1.sds130 obsoletes libva-devel = 1:0.31.0-1.sds13.fc13 libva-freeworld-devel.x86_64: W: no-documentation libva-freeworld-utils.x86_64: W: self-obsoletion libva-utils < 0.31.0.1.sds130 obsoletes libva-utils = 1:0.31.0-1.sds13.fc13 libva-freeworld-utils.x86_64: W: no-documentation libva-freeworld-utils.x86_64: W: no-manual-page-for-binary libva_h264encode libva-freeworld-utils.x86_64: W: no-manual-page-for-binary libva_test_10 libva-freeworld-utils.x86_64: W: no-manual-page-for-binary mpeg2vldemo libva-freeworld-utils.x86_64: W: no-manual-page-for-binary libva_test_11 libva-freeworld-utils.x86_64: W: no-manual-page-for-binary putsurface libva-freeworld-utils.x86_64: W: no-manual-page-for-binary libva_test_05 libva-freeworld-utils.x86_64: W: no-manual-page-for-binary libva_test_04 libva-freeworld-utils.x86_64: W: no-manual-page-for-binary libva_test_07 libva-freeworld-utils.x86_64: W: no-manual-page-for-binary libva_test_06 libva-freeworld-utils.x86_64: W: no-manual-page-for-binary libva_test_01 libva-freeworld-utils.x86_64: W: no-manual-page-for-binary libva_test_03 libva-freeworld-utils.x86_64: W: no-manual-page-for-binary libva_test_02 libva-freeworld-utils.x86_64: W: no-manual-page-for-binary libva_test_09 libva-freeworld-utils.x86_64: W: no-manual-page-for-binary libva_test_08 libva-freeworld.src:58: W: macro-in-comment %{_includedir} libva-freeworld.src:23: W: mixed-use-of-spaces-and-tabs (spaces: line 23, tab: line 1) - package meets naming guidelines - package meets packaging guidelines - license (MIT) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r Needs work: - Hmm, I had not thought about the need for an epoch in the virtual provides / obsoletes. I can understand that you want to keep a clean upgrade path from 3th party repositories already carying this. In that case I would prefer to stick with the previous versioning scheme until a new upstream release is made (sorry about this). - rpmlint: libva-freeworld.x86_64: W: self-obsoletion libva < 0.31.0.1.sds130 obsoletes libva = 1:0.31.0-1.sds13.fc13 libva-freeworld-devel.x86_64: W: self-obsoletion libva-devel < 0.31.0.1.sds130 obsoletes libva-devel = 1:0.31.0-1.sds13.fc13 libva-freeworld-utils.x86_64: W: self-obsoletion libva-utils < 0.31.0.1.sds130 obsoletes libva-utils = 1:0.31.0-1.sds13.fc13 I guess rpmlint wants to see an explicit epoch 0 in the obsoletes, but this does not matter if we switch back to the old versioning screen. -rpmlint: libva-freeworld.src:23: W: mixed-use-of-spaces-and-tabs (spaces: line 23, tab: line 1) -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1321 --- Comment #9 from Adam Williamson <adamwill(a)shaw.ca&gt; 2010-07-16 17:23:22 --- Note that upstream is up to 0.31.1+sds4 - http://www.splitted-desktop.com/~gbeauchesne/libva/ -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1321 --- Comment #11 from Adam Williamson <adamwill(a)shaw.ca&gt; 2010-07-16 18:35:51 --- fwiw, I checked with Gwenole and he says he can't see any particular reason to ship the tests, so it's fine that those are dropped. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1321 NicolasChauvet <kwizart(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33 --- Comment #13 from NicolasChauvet <kwizart(a)gmail.com&gt; 2010-07-17 16:56:20 --- Package CVS request ====================== Package Name: libva-freeworld Short Description: cmdline MPEG audio player Owners: kwizart , adamwill Branches: F-12 F-13 InitialCC: Thx for the review. As I'm away, I will proceed on CVS import on monday. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1321 NicolasChauvet <kwizart(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #14 from NicolasChauvet <kwizart(a)gmail.com&gt; 2010-08-10 10:51:45 --- libva-freeworld is imported. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.