http://bugzilla.rpmfusion.org/show_bug.cgi?id=751 Hicham HAOUARI <hicham.haouari(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |754 -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=751 --- Comment #2 from Lubomir Rintel <lkundrak(a)v3.sk&gt; 2009-08-09 18:23:32 --- Created an attachment (id=242) --> (http://bugzilla.rpmfusion.org/attachment.cgi?id=242) Look up the library paths for RPM Fusion's VirtualBox-OSE correcty 1.) Make the package noarch. See, you're using /usr/lib, not %{_libdir}, so that it won't be different on a 64-bit architecture #this package can't be noarch, since it is using /usr/lib directory, so we have to explicitly disable debuginfo package %global debug_package %{nil} 2.) Adjust the packaging for python-VirtualBox-OSE VirtualBox-OSE 3.0.4-2 contains the python- subpackage. It will be available for Fedora 11 as well shortly. http://buildsys.rpmfusion.org/build-status/job.psp?uid=4623 Requires: VirtualBox-OSE >= 2.2.2 Requires: VirtualBox-OSE-devel >= 2.2.2 I've split off the Python bindings so that you don't have to depend on the -devel package. Please require that instead. The require of VirtualBox-OSE itself is useless, since it's depended on by python-. Source1: VBoxGtk Please don't modify PYTHONPATH. Look at the attached patch for how should we look up the python modules and eventually send that upstream. 3.) Don't maximize the window. #Patch1: start the main window maximized Patch1: vboxgtk-vboxgtk_iface.py.patch This is something that should be left on window manager/user setting. 4.) Please upstream the desktop file validity fixes Send that to the author and add a comment to the spec file. https://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_ha... #Patch0: fix the vboxgtk desktop file Patch0: vboxgtk-vboxgtk.desktop.in 5.) Please fix the description """ Most of VirtualBox features are not supported, and those that are will probably fail. """ Were this true, this package could never be accepted. Please either drop this, or replace it with description of the package _does_ instead of what it does not. Also, please be careful to refer to VirtualBox OSE, not VirtualBox. 6.) Please use %find_lang %lang(es) %{_datadir}/locale/es/LC_MESSAGES/%{name}.mo https://fedoraproject.org/wiki/Packaging/Guidelines#Why_do_we_need_to_use... -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=751 --- Comment #4 from Hicham HAOUARI <hicham.haouari(a)gmail.com&gt; 2009-08-09 20:01:03 --- The patch you provided didn't work for me. 1)Fixed. 2)Waiting for VirtualBox-OSE update. I suggest that you name the python subpackage VirtualBox-OSE-python to make it clear that it is a subpackage, not a separate binding. 3)Fixed. 4)Sent : https://sourceforge.net/tracker/?func=detail&aid=2834528&group_id... 5)Fixed : A simple GTK frontend for VirtualBox. 6)Fixed. I am a sponsored fedora packager, and I own three packages till now : https://admin.fedoraproject.org/pkgdb/users/packages/hicham?_csrf_token=7... Spec URL : http://hicham.fedorapeople.org/vboxgtk.spec SRPM URL: http://hicham.fedorapeople.org/vboxgtk-0.5.0-2.fc11.src.rpm rpmlint output: spec and srpm : none binary rpm : vboxgtk.noarch: E: devel-dependency VirtualBox-OSE-devel 1 packages and 0 specfiles checked; 1 errors, 0 warnings. This warning will be off when new VirtualBox-OSE-python package will be released. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=751 --- Comment #6 from Hicham HAOUARI <hicham.haouari(a)gmail.com&gt; 2009-08-09 20:44:44 --- my account is hicham. I need to test the patch before committing the package to cvs. I will wait until VirtualBox-OSE-3.0.4 is pushed to updates. I will also change the dependency to python-VirtualBox-OSE. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=751 --- Comment #8 from Hicham HAOUARI <hicham.haouari(a)gmail.com&gt; 2009-08-09 22:06:29 --- updated spec and srpm Spec URL : http://hicham.fedorapeople.org/vboxgtk.spec SRPM URL: http://hicham.fedorapeople.org/vboxgtk-0.5.0-2.fc11.src.rpm rpmlint output: none -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=751 --- Comment #10 from Todd Zullinger <tmz(a)pobox.com&gt; 2009-08-11 17:05:13 --- (In reply to comment #9) Wouldn't it be sufficient (and much easier on the eyes) to use: ExclusiveArch: %{ix86} x86_64 ? -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=751 Hicham HAOUARI <hicham.haouari(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33 -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=751 --- Comment #13 from Hicham HAOUARI <hicham.haouari(a)gmail.com&gt; 2009-08-11 17:51:02 --- Package CVS request ====================== Package Name: vboxgtk Short Description: A simple GTK frontend for VirtualBox Owners: hicham Branches: F-10 F-11 InitialCC: hicham ---------------------- License tag: free -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=751 Thorsten Leemhuis <fedora(a)leemhuis.info&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33 | --- Comment #15 from Thorsten Leemhuis <fedora(a)leemhuis.info&gt; 2009-08-12 10:22:28 --- (In reply to comment #14) done -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=751 Hicham HAOUARI <hicham.haouari(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #17 from Hicham HAOUARI <hicham.haouari(a)gmail.com&gt; 2009-11-01 15:52:34 --- yes, it have been successfully imported. you can close this review. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.