http://bugzilla.rpmfusion.org/show_bug.cgi?id=1252 Orcan Ogetbil <oget.fedora(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oget.fedora(a)gmail.com Blocks|2 |3 AssignedTo|rpmfusion-package- |oget.fedora(a)gmail.com |review(a)rpmfusion.org | --- Comment #2 from Orcan Ogetbil <oget.fedora(a)gmail.com&gt; 2010-06-26 23:54:22 --- I made a full review on this. Here are my comments, notes: ! The patch is nice and clean, and can be upstreamed. Please provide a link in the specfile as comment if you do so. ! Note that since you BR: pdflib-lite-devel, package has to go to rpmfusion-nonfree. - rpmlint is silent ? The package bundles a copy of xpdf which is available in Fedora. Is it possible to patch it out? * Parts of the software carry different licenses. For example: lib/MD5.c is BSD lib/action/actioncompiler.c is LGPLv2+ lib/action/swfcompiler.tab.c is GPLv3+ I didn't find any license conflicts though. Please fish these all out and list them in the License tag of the specfile with comments about which files belong to what license. ! Please try to make the description span 80 columns as much as possible (it is set to 70 columns right now). -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1252 --- Comment #4 from Kevin Kofler <kevin.kofler(a)chello.at&gt; 2010-06-29 09:14:45 --- You can't link a GPLed program against a GPL-incompatible library such as pdflib-lite. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1252 --- Comment #6 from Kevin Kofler <kevin.kofler(a)chello.at&gt; 2010-07-01 15:27:21 --- As the FAQ says, you need an explicit exception to the GPL (from the copyright holders) as per http://www.gnu.org/licenses/gpl-faq.html#GPLIncompatibleLibs to be able to ship such a combination. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1252 Orion Poplawski <orion(a)cora.nwra.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |orion(a)cora.nwra.com --- Comment #8 from Orion Poplawski <orion(a)cora.nwra.com&gt; 2010-10-01 20:17:56 --- Couple things I came across packaging this up myself: File encoding (in %prep): # Convert files to UTF-8 for file in AUTHORS src/{jpeg2swf,swfstrings}.1; do iconv -f ISO-8859-1 -t UTF-8 -o $file.new $file && touch -r $file $file.new && mv $file.new $file I have in addition: BuildRequires: fftw-devel BuildRequires: lame-devel BuildRequires: zziplib-devel -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1252 --- Comment #10 from Orcan Ogetbil <oget.fedora(a)gmail.com&gt; 2010-11-01 17:28:15 --- I wonder if there is any activity going on in here. The package submitter did not make a comment since the original message. Mohamed, any progress on this? What is your take on the suggestions listed above? -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1252 --- Comment #12 from Mohamed El Morabity <pikachu.2014(a)gmail.com&gt; 2010-11-11 17:38:28 --- As promised, here is a new version: SPEC URL: http://pikachu.2014.free.fr/public/swftools/swftools.spec SRPM URL: http://pikachu.2014.free.fr/public/swftools/swftools-0.9.1-2.fc14.src.rpm Build logs: http://pikachu.2014.free.fr/public/swftools/build.log I added fftw-devel and zziplib-devel as BR, as suggested by Orion in comment #8. I also re-enabled the build of Python modules. I mentionned too the other licenses as asked by Orcan in comment #2. About the prefix patch, it seems it was already suggested: http://lists.nongnu.org/archive/html/swftools-common/2009-06/msg00079.html With no effects... About the license issue, I've just sent a message on the SWFTools mailing list: http://lists.nongnu.org/archive/html/swftools-common/2010-11/msg00084.html (In reply to comment #2) I see no way to link against xpdf, no API or such is provided in the Fedora package. The sources embed a copy of gocr too, with the same problem. (In reply to comment #9) Unless I directly submit the devel version here, I don't think guidelines would allow such a "double" packaging of swftools. (In reply to comment #3) Done. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1252 --- Comment #14 from Orcan Ogetbil <oget.fedora(a)gmail.com&gt; 2011-01-06 15:10:58 --- Hi Mohamed, Upstream didn't take action about the license issue for linking to pdflib. We can't ship this as is. It would be illegal. Please ping the upstream instead. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1252 Hicham HAOUARI <hicham.haouari(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hicham.haouari(a)gmail.com --- Comment #16 from Hicham HAOUARI <hicham.haouari(a)gmail.com&gt; 2011-01-30 16:12:50 --- why not remove lame dep and get this package into fedora proper ? -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1252 --- Comment #18 from Orion Poplawski <orion(a)cora.nwra.com&gt; 2011-01-31 17:15:18 --- Is anyone aware of any attempt to get upstream to support something like gstreamer for mp3 support? -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1252 David Timms <dtimms(a)iinet.net.au&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dtimms(a)iinet.net.au --- Comment #20 from David Timms <dtimms(a)iinet.net.au&gt; 2011-06-20 15:14:04 --- (In reply to comment #18) Does anyone know of example source code where a similar transition to gstreamer code has been performed, in the same language that this package is written in ? (I'm hoping it could be used to more quickly add gstreamer support) -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1252 --- Comment #22 from Pablo Rodriguez <rpmfusion(a)pragmata.tk&gt; 2011-07-17 12:42:58 --- Sorry if I miss the issue here, but let me to make one point. A new package has been submitted for proposal. swftools (as any other piece of code) could have different dependencies than it really has, but these are the dependencies this particular package has. After a year, I guess that the next step would be to accept it as it is or reject the proposal. Just in case it helps. Pablo -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1252 --- Comment #24 from Mohamed El Morabity <pikachu.2014(a)gmail.com&gt; 2011-10-06 21:50:28 --- (In reply to comment #23) i'm still interested. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.