12:23 p.m.
http://bugzilla.rpmfusion.org/show_bug.cgi?id=34
Summary: Review request: xmltv - A set of utilities to manage
your TV viewing
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: kwizart(a)gmail.com
Estimated Hours: 0.0
SRPM:
http://rpms.kwizart.net/fedora/reviews/xmltv/xmltv-0.5.52-2.fc8.kwizart.s...
SPEC:
http://rpms.kwizart.net/fedora/reviews/xmltv/xmltv.spec
Summary: A set of utilities to manage your TV viewing
This package cannot be allowed in Fedora since it retrieve information from
websites and thus could possibly violate EULA.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
12:24 p.m.
New subject: [Bug 34] Review request: xmltv - A set of utilities to manage your TV viewing
http://bugzilla.rpmfusion.org/show_bug.cgi?id=34
NicolasChauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |2
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
2:32 p.m.
New subject: [Bug 34] Review request: xmltv - A set of utilities to manage your TV viewing
http://bugzilla.rpmfusion.org/show_bug.cgi?id=34
Xavier Bachelot <xavier(a)bachelot.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |xavier(a)bachelot.org
--- Comment #1 from Xavier Bachelot <xavier(a)bachelot.org> 2008-07-30 16:32:39 ---
Here's some initial comments from a quick build :
* rpmlint output not empty :
xmltv.noarch: E: non-standard-executable-perm
/usr/bin/tv_remove_some_overlapping 0555
xmltv.noarch: E: non-standard-executable-perm /usr/bin/tv_sort 0555
xmltv.noarch: E: non-standard-executable-perm /usr/bin/tv_to_text 0555
xmltv.noarch: E: non-standard-executable-perm /usr/bin/tv_to_potatoe 0555
xmltv.noarch: E: non-standard-executable-perm /usr/bin/tv_imdb 0555
xmltv.noarch: E: non-standard-executable-perm /usr/bin/tv_to_latex 0555
xmltv.noarch: E: non-standard-executable-perm /usr/bin/tv_validate_grabber 0555
xmltv.noarch: E: non-standard-executable-perm /usr/bin/tv_split 0555
xmltv.noarch: E: non-standard-executable-perm /usr/bin/tv_extractinfo_en 0555
xmltv.noarch: E: non-standard-executable-perm /usr/bin/tv_grep 0555
xmltv.noarch: E: non-standard-executable-perm /usr/bin/tv_find_grabbers 0555
xmltv.noarch: E: non-standard-executable-perm /usr/bin/tv_cat 0555
xmltv.noarch: E: non-standard-executable-perm /usr/bin/tv_validate_file 0555
xmltv.noarch: W: file-not-utf8 /usr/share/doc/xmltv-0.5.52/ChangeLog
xmltv-grabbers.noarch: E: non-standard-executable-perm
/usr/bin/tv_grab_eu_epgdata 0555
xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_be 0555
xmltv-grabbers.noarch: E: non-standard-executable-perm
/usr/bin/tv_grab_no_gfeed 0555
xmltv-grabbers.noarch: E: non-standard-executable-perm
/usr/bin/tv_grab_ch_search 0555
xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_fr 0555
xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_na_dd
0555
xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_pt 0555
xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_es 0555
xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_na_dtv
0555
xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_za 0555
xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_ee 0555
xmltv-grabbers.noarch: E: non-standard-executable-perm
/usr/bin/tv_grab_es_laguiatv 0555
xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_uk_rt
0555
xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_it 0555
xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_dtv_la
0555
xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_br_net
0555
xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_re 0555
xmltv-grabbers.noarch: E: non-standard-executable-perm
/usr/bin/tv_grab_combiner 0555
xmltv-grabbers.noarch: E: non-standard-executable-perm
/usr/bin/tv_grab_es_miguiatv 0555
xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_ar 0555
xmltv-grabbers.noarch: E: non-standard-executable-perm
/usr/bin/tv_grab_se_swedb 0555
xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_uk_bleb
0555
xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_jp 0555
xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_hr 0555
xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_huro
0555
xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_dk 0555
xmltv-grabbers.noarch: E: non-standard-executable-perm
/usr/bin/tv_grab_na_icons 0555
xmltv-grabbers.noarch: E: non-standard-executable-perm /usr/bin/tv_grab_fi 0555
xmltv-gui.noarch: E: non-standard-executable-perm /usr/bin/tv_check 0555
* Duplicate requires in xmltv-grabbers :
perl(WWW::Mechanize)
perl(WWW::Mechanize) >= 1.02
perl(XML::Twig)
perl(XML::Twig) >= 3.10
perl(XML::Twig) >= 3.28
* Does the main package needs to require -gui ?
* Suggested additional BR: perl(Log::TraceMessages) (for debug purposes, from
the README file)
* add some of the doc/ subdir files to %%doc
* make test needs to be fixed if at all possible. If not, only the failing
tests should be disabled, not all of them.
* missing desktop file for xmltv-gui
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
2:21 p.m.
New subject: [Bug 34] Review request: xmltv - A set of utilities to manage your TV viewing
http://bugzilla.rpmfusion.org/show_bug.cgi?id=34
--- Comment #2 from NicolasChauvet <kwizart(a)gmail.com> 2008-08-08 16:21:34 ---
Suggested additional BR: perl(Log::TraceMessages) (for debug
purposes, from
the README file)
Anyone can take this (and dependencies ?)
https://bugzilla.redhat.com/show_bug.cgi?id=458449
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
7:10 p.m.
New subject: [Bug 34] Review request: xmltv - A set of utilities to manage your TV viewing
http://bugzilla.rpmfusion.org/show_bug.cgi?id=34
--- Comment #3 from NicolasChauvet <kwizart(a)gmail.com> 2008-10-14 21:10:30 ---
SRPM:
http://rpms.kwizart.net/fedora/reviews/xmltv/xmltv-0.5.53-1.fc8.kwizart.s...
SPEC:
http://rpms.kwizart.net/fedora/reviews/xmltv/xmltv.spec
Summary: A set of utilities to manage your TV viewing
- Update to 0.5.53
- Remove -gui requirement on main
- filter perl-Tk dependency on perl-XMLTV
- Re-enable make test
* I don't think that creating a .desktop file is that necessary. I don't use
that script often (never) anyway. But splitting it in a -gui subpackage will
prevent to requires perl-Tk and Thus, huge gui dependencies.
* Duplicate requires can probably be fixed by using the same value when "use" a
perl package. That been said i cannot see any side effect and it will remains
developpers care to request the same version.
The others points should have been fixed.
perl-Log-TraceMessages has been pushed to stable for F-8/F-9 today which is the
last dependency that was missing. It is already available for Rawhide, right
now.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
10:26 a.m.
New subject: [Bug 34] Review request: xmltv - A set of utilities to manage your TV viewing
http://bugzilla.rpmfusion.org/show_bug.cgi?id=34
--- Comment #4 from Xavier Bachelot <xavier(a)bachelot.org> 2008-10-15 12:26:53 ---
* Duplicate Requires: in xmltv-grabbers :
perl(WWW::Mechanize)
perl(WWW::Mechanize) >= 1.02
perl(XML::Twig)
perl(XML::Twig) >= 3.10
perl(XML::Twig) >= 3.28
Different grabbers require different versions of the same modules. I'd say the
duplicates are harmless in this case. Filter them if you wish but I won't block
on that.
* missing desktop file for xmltv-gui
The Fedora guidelines are pretty strict on this, so even if the use case is
limited here, it'd be better to have one.
https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files
Either http://wiki.xmltv.org/favicon.ico or http://wiki.xmltv.org/logo.png can
be used for the icon.
* Islandic grabber is not built. Adding the following fixes it :
BuildRequires: perl(XML::DOM)
BuildRequires: perl(XML::LibXSLT)
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
1:27 p.m.
New subject: [Bug 34] Review request: xmltv - A set of utilities to manage your TV viewing
http://bugzilla.rpmfusion.org/show_bug.cgi?id=34
--- Comment #5 from NicolasChauvet <kwizart(a)gmail.com> 2008-10-15 15:27:07 ---
(In reply to comment #4)
* missing desktop file for xmltv-gui
The Fedora guidelines are pretty strict on this, so even if the use case is
limited here, it'd be better to have one.
https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files
Either http://wiki.xmltv.org/favicon.ico or http://wiki.xmltv.org/logo.png can
be used for the icon.
So..., I have investigated.
The normal use would be to have:
tv_check --scan --listings /someplace/XMLTV_grabbed.xml --shows
~/.xmltv/shows.xml
(it would need to be --configured before).
XMLTV_grabbed.xml is usually generated from tv_grab_yourlocale but there is no
sure way where to expect this file.(It depend on where the related apps store
the file, but system wide TV.xml file isn't common). Also shows.xml are user
dependant, but might be different than the current users. (for example if user
schlobinux want to check shows from mythtv or freevo within the schlobinux X
session).
I would add that .desktop files aren't designed to support parsing of two files
until now, so it doesn't worth the case to use this as it will lead to hardcode
the path, whereas it can change often and for different uses.
* Islandic grabber is not built. Adding the following fixes it :
BuildRequires: perl(XML::DOM)
BuildRequires: perl(XML::LibXSLT)
Fixed and mock tested in Rawhide and F-8 (it
works).
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
10:41 p.m.
New subject: [Bug 34] Review request: xmltv - A set of utilities to manage your TV viewing
http://bugzilla.rpmfusion.org/show_bug.cgi?id=34
Xavier Bachelot <xavier(a)bachelot.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #6 from Xavier Bachelot <xavier(a)bachelot.org> 2008-10-20 00:41:25 ---
+ source files match upstream :9ee2d6c8bb192e214b2674042260cf36
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license
+ license is open source-compatible. License text is included.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock.
+ package installs properly
+ rpmlint is silent.
= final provides and requires are sane:
Some duplicates requires with different versions specified. Harmless,
perl(WWW::Mechanize)
perl(WWW::Mechanize) >= 1.02
perl(XML::Twig)
perl(XML::Twig) >= 3.10
perl(XML::Twig) >= 3.28
+ %check is present and all tests pass
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
= No desktop file, but it's not really useful in this case.
This package is APPROVED.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
8:07 a.m.
New subject: [Bug 34] Review request: xmltv - A set of utilities to manage your TV viewing
http://bugzilla.rpmfusion.org/show_bug.cgi?id=34
NicolasChauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |33
Blocks|2 |4
--- Comment #7 from NicolasChauvet <kwizart(a)gmail.com> 2008-10-20 10:07:15 ---
Package CVS request
======================
Package Name: xmltv
Short Description: A set of utilities to manage your TV viewing
Owners: kwizart
Branch: devel F-9 F-8 EL-5
InitialCC:
----------------------
License tag: free
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
8:45 a.m.
New subject: [Bug 34] Review request: xmltv - A set of utilities to manage your TV viewing
http://bugzilla.rpmfusion.org/show_bug.cgi?id=34
Xavier Lamien <lxtnow(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|33 |
--- Comment #8 from Xavier Lamien <lxtnow(a)gmail.com> 2008-10-20 10:45:21 ---
cvs done.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
11:14 a.m.
New subject: [Bug 34] Review request: xmltv - A set of utilities to manage your TV viewing
http://bugzilla.rpmfusion.org/show_bug.cgi?id=34
NicolasChauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|4 |
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #9 from NicolasChauvet <kwizart(a)gmail.com> 2008-10-31 12:14:17 ---
package imported.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
2:46 p.m.
New subject: [Bug 34] Review request: xmltv - A set of utilities to manage your TV viewing
On 31.10.2008 12:14, RPM Fusion Bugzilla wrote:
http://bugzilla.rpmfusion.org/show_bug.cgi?id=34
NicolasChauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|4 |
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #9 from NicolasChauvet <kwizart(a)gmail.com> 2008-10-31 12:14:17 ---
package imported.
Does anybody really care about "Bug 4 (Tracker: Accepted packages.)". If
yes then we should leave the blocker after importing (¹).
CU
knurd
(¹) note that we have Bug 33 for CVS requests; hence I'd say that we
should use just that for all CVS admin requests (including branch
request for new packages)
12:42 p.m.
New subject: [Bug 34] Review request: xmltv - A set of utilities to manage your TV viewing
http://bugzilla.rpmfusion.org/show_bug.cgi?id=34
Thorsten Leemhuis <fedora(a)leemhuis.info> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |4
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
5570
days inactive
5749
days old
rpmfusion-developers@lists.rpmfusion.org
12 comments
2 participants
participants (2)
-
RPM Fusion Bugzilla -
Thorsten Leemhuis