10:01 p.m.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3289
Bug #: 3289
Summary: Review request: libopenshot-audio1 - Audio library
used by OpenShot
Classification: Unclassified
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: jonathan(a)openshot.org
CC: rpmfusion-package-review(a)rpmfusion.org
Blocks: 2, 30
OpenShot Audio Library (libopenshot-audio) is an open-source
project powered by JUCE, and enables high-quality audio editing
and playback for libopenshot.
SPEC & SRPM files:
https://launchpad.net/libopenshot/0.0/0.0.2/+download/libopenshot-audio.spec
https://launchpad.net/libopenshot/0.0/0.0.2/+download/libopenshot-audio1-...
Not eligible for Fedora due to FFmpeg / LibAV dependencies.
This is my first RPM Fusion package, and I look forward to learning from this
experience. I am also the main developer of OpenShot Video Editor, and look
forward to getting these packages reviewed and posted in RPM Fusion. =)
I am seeking a sponsor for this package, and a related package (libopenshot)
soon to be filed in another bug report.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:45 p.m.
New subject: [Bug 3289] Review request: libopenshot-audio1 - Audio library used by OpenShot
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3289
Richard <hobbes1069(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hobbes1069(a)gmail.com
Blocks| |3290
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:38 p.m.
New subject: [Bug 3289] Review request: libopenshot-audio1 - Audio library used by OpenShot
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3289
--- Comment #1 from Jonathan Thomas <jonathan(a)openshot.org> 2014-07-29 22:38:24 CEST
---
I have updated the SPEC file for libopenshot-audio, based on feedback from
Richard:
https://launchpad.net/libopenshot/0.0/0.0.3/+download/libopenshot-audio.spec
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:30 p.m.
New subject: [Bug 3289] Review request: libopenshot-audio - Audio library used by OpenShot
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3289
Richard <hobbes1069(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|30 |
Summary|Review request: |Review request:
|libopenshot-audio1 - Audio |libopenshot-audio - Audio
|library used by OpenShot |library used by OpenShot
--- Comment #2 from Richard <hobbes1069(a)gmail.com> 2014-08-08 22:30:37 CEST ---
Ok, I'm taking over the review if that's OK. That solves the problem of
sponsorship and keeps Jonathan programming instead of worrying about packaing
:)
SPEC: https://dl.dropboxusercontent.com/u/34775202/libopenshot-audio.spec
SRPM:
https://dl.dropboxusercontent.com/u/34775202/libopenshot-audio-0.0.3-1.fc...
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:31 a.m.
New subject: [Bug 3289] Review request: libopenshot-audio - Audio library used by OpenShot
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3289
Sérgio Basto <sergio(a)serjux.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |sergio(a)serjux.com
--- Comment #3 from Sérgio Basto <sergio(a)serjux.com> 2014-08-09 04:31:04 CEST ---
it is a very simple spec
fedora-review --other-bz https://bugzilla.rpmfusion.org -b 3289
with only 4 warnings
# rpmlint libopenshot-audio libopenshot-audio-devel
libopenshot-audio.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libopenshot-audio.so.0.0.3 /lib64/libSM.so.6
libopenshot-audio.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libopenshot-audio.so.0.0.3 /lib64/libICE.so.6
libopenshot-audio.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libopenshot-audio.so.0.0.3 /lib64/libXinerama.so.1
libopenshot-audio-devel.x86_64: W: only-non-binary-in-usr-lib
2 packages and 0 specfiles checked; 0 errors, 4 warnings.
http://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib-d...
doesn't seem to be worrying.
Package APPROVED !
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:12 a.m.
New subject: [Bug 3289] Review request: libopenshot-audio - Audio library used by OpenShot
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3289
Dominik 'Rathann' Mierzejewski <rpm(a)greysector.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rpm(a)greysector.net
--- Comment #4 from Dominik 'Rathann' Mierzejewski <rpm(a)greysector.net>
2014-08-09 09:12:42 CEST ---
(In reply to comment #3)
it is a very simple spec
fedora-review --other-bz https://bugzilla.rpmfusion.org -b 3289
with only 4 warnings
# rpmlint libopenshot-audio libopenshot-audio-devel
libopenshot-audio.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libopenshot-audio.so.0.0.3 /lib64/libSM.so.6
libopenshot-audio.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libopenshot-audio.so.0.0.3 /lib64/libICE.so.6
libopenshot-audio.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libopenshot-audio.so.0.0.3 /lib64/libXinerama.so.1
libopenshot-audio-devel.x86_64: W: only-non-binary-in-usr-lib
2 packages and 0 specfiles checked; 0 errors, 4 warnings.
http://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib-d...
doesn't seem to be worrying.
But it can be easily fixed, just drop the aforementioned libraries from final
linker call.
Please fix before importing.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:35 p.m.
New subject: [Bug 3289] Review request: libopenshot-audio - Audio library used by OpenShot
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3289
--- Comment #5 from Richard <hobbes1069(a)gmail.com> 2014-08-09 20:35:22 CEST ---
Unless closely managed, cmake tends to "collect" libraries but a simple
"-Wl,--as-needed" should take care of it.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:42 p.m.
New subject: [Bug 3289] Review request: libopenshot-audio - Audio library used by OpenShot
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3289
Richard <hobbes1069(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|2 |3, 33
--- Comment #6 from Richard <hobbes1069(a)gmail.com> 2014-08-09 20:42:42 CEST ---
New Package CVS Request
=======================
Package Name: libopenshot-audio
Short Description: Audio library used by OpenShot
Owners: hobbes1069(a)gmail.com
Branches: f20
InitialCC:
Cvsextras Commits: yes
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:43 p.m.
New subject: [Bug 3289] Review request: libopenshot-audio - Audio library used by OpenShot
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3289
Richard <hobbes1069(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|3 |4
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:12 p.m.
New subject: [Bug 3289] Review request: libopenshot-audio - Audio library used by OpenShot
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3289
--- Comment #7 from Sérgio Basto <sergio(a)serjux.com> 2014-08-10 00:12:23 CEST ---
(In reply to comment #5)
Unless closely managed, cmake tends to "collect" libraries
but a simple
"-Wl,--as-needed" should take care of it.
yeah , add [1] fix it.
[1]
%global optflags %(echo %{optflags} -Wl,--as-needed )
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:31 p.m.
New subject: [Bug 3289] Review request: libopenshot-audio - Audio library used by OpenShot
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3289
Nicolas Chauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|33 |
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:38 p.m.
New subject: [Bug 3289] Review request: libopenshot-audio - Audio library used by OpenShot
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3289
--- Comment #8 from Sérgio Basto <sergio(a)serjux.com> 2014-09-04 16:38:49 CEST ---
Hello , we got scm request done , when this package is done and publish in
devel ,
I can review libopenshot ...
Thanks,
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:27 a.m.
New subject: [Bug 3289] Review request: libopenshot-audio - Audio library used by OpenShot
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3289
Richard <hobbes1069(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #9 from Richard <hobbes1069(a)gmail.com> 2014-09-05 04:27:53 CEST ---
Builds done for rawhide and F-20.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3514
days inactive
3566
days old
rpmfusion-developers@lists.rpmfusion.org
12 comments
1 participants
participants (1)
-
RPM Fusion Bugzilla