[Bug 1975] New: "Review request: arista - An easy to use multimedia transcoder for the GNOME Desktop
11 p.m.
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1975
Summary: "Review request: arista - An easy to use multimedia
transcoder for the GNOME Desktop
Product: Package Reviews
Version: Current
Platform: All
URL: http://deogracia.free.fr/RPMS/arista.spec
http://deogracia.free.fr/RPMS/arista-0.9.7-
2.fc15.src.rpm
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: deogracia(a)free.fr
CC: rpmfusion-package-review(a)rpmfusion.org
Blocks: 2,30
Estimated Hours: 0.0
Hi guys!
It's my first rpm. So can someone sponsor me please?
Arista is an easy to use multimedia transcoder for the GNOME Desktop. Arista
focuses on being easy to use by making the complex task of encoding
for various devices simple. Pick your input, pick your target device,
choose a file to save to and go.
As someone said in the wish-list, arista transcoder depends on some RPM Fusion
packages.
Here's the rpmlint logs on the source rpm and the binairies pacakges.
rpmlint rpmbuild/SRPMS/arista-0.9.7-2.fc15.src.rpm
arista.src: W: spelling-error Summary(en_US) transcoder -> trans coder,
trans-coder, transponder
arista.src: W: spelling-error %description -l en_US transcoder -> trans coder,
trans-coder, transponder
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
rpmlint rpmbuild/RPMS/noarch/arista-0.9.7-2.fc15.noarch.rpm
arista.noarch: W: spelling-error Summary(en_US) transcoder -> trans coder,
trans-coder, transponder
arista.noarch: W: spelling-error %description -l en_US transcoder -> trans
coder, trans-coder, transponder
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
rpmlint
/home/deogracia/rpmbuild/RPMS/noarch/nautilus-extension-arista-0.9.7-2.fc15.noarch.rpm
nautilus-extension-arista.noarch: W: spelling-error %description -l en_US
transcoder -> trans coder, trans-coder, transponder
nautilus-extension-arista.noarch: W: spelling-error %description -l en_US
transcoding -> trans coding, trans-coding, transcending
nautilus-extension-arista.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
I chose to ignore these warning because for the spelling error, it 's on the
name / baseline of the software. For the no documentation, since it's an
extension, the documention lies with the core package
Thank you !
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:06 a.m.
New subject: [Bug 1975] "Review request: arista - An easy to use multimedia transcoder for the GNOME Desktop
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1975
leigh scott <leigh123linux(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |leigh123linux@fedoraproject.
| |org
--- Comment #1 from leigh scott <leigh123linux(a)fedoraproject.org> 2011-10-09
12:06:29 ---
(In reply to comment #0)
Hi guys!
It's my first rpm.
I see no links to the srpm or spec file.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:24 a.m.
New subject: [Bug 1975] "Review request: arista - An easy to use multimedia transcoder for the GNOME Desktop
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1975
--- Comment #2 from leigh scott <leigh123linux(a)fedoraproject.org> 2011-10-09
12:24:17 ---
(In reply to comment #0)
Hi guys!
It's my first rpm. So can someone sponsor me please?
Arista is an easy to use multimedia transcoder for the GNOME Desktop. Arista
focuses on being easy to use by making the complex task of encoding
for various devices simple. Pick your input, pick your target device,
choose a file to save to and go.
As someone said in the wish-list, arista transcoder depends on some RPM Fusion
packages.
Here's the rpmlint logs on the source rpm and the binairies pacakges.
rpmlint rpmbuild/SRPMS/arista-0.9.7-2.fc15.src.rpm
arista.src: W: spelling-error Summary(en_US) transcoder -> trans coder,
trans-coder, transponder
arista.src: W: spelling-error %description -l en_US transcoder -> trans coder,
trans-coder, transponder
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
rpmlint rpmbuild/RPMS/noarch/arista-0.9.7-2.fc15.noarch.rpm
arista.noarch: W: spelling-error Summary(en_US) transcoder -> trans coder,
trans-coder, transponder
arista.noarch: W: spelling-error %description -l en_US transcoder -> trans
coder, trans-coder, transponder
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
rpmlint
/home/deogracia/rpmbuild/RPMS/noarch/nautilus-extension-arista-0.9.7-2.fc15.noarch.rpm
nautilus-extension-arista.noarch: W: spelling-error %description -l en_US
transcoder -> trans coder, trans-coder, transponder
nautilus-extension-arista.noarch: W: spelling-error %description -l en_US
transcoding -> trans coding, trans-coding, transcending
nautilus-extension-arista.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
I chose to ignore these warning because for the spelling error, it 's on the
name / baseline of the software. For the no documentation, since it's an
extension, the documention lies with the core package
Thank you !
Spec: http://deogracia.free.fr/RPMS/arista.spec
Srpm: http://deogracia.free.fr/RPMS/arista-0.9.7-2.fc15.src.rpm
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:46 a.m.
New subject: [Bug 1975] "Review request: arista - An easy to use multimedia transcoder for the GNOME Desktop
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1975
--- Comment #3 from leigh scott <leigh123linux(a)fedoraproject.org> 2011-10-09
12:46:15 ---
Just a few comments
1. it requires nautilus-extensions
2. what propose do these macros serve as there not called
%define python_compile_opt python -O -c "import compileall;
compileall.compile_dir('.')"
%define python_compile python -c "import compileall;
compileall.compile_dir('.')"
https://fedoraproject.org/wiki/Packaging/Python#System_Architecture
It's noarch so opt flags aren't required, use this instead
%build
%{__python} setup.py build
%install
%{__python} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT
3. %fupes is not correct, use fupes instead
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:49 a.m.
New subject: [Bug 1975] Review request: arista - An easy to use multimedia transcoder for the GNOME Desktop
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1975
Nicolas Chauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
URL|http://deogracia.free.fr/RPM|
|S/arista.spec |
|http://deogracia.free.fr/RPM|
|S/arista-0.9.7- |
|2.fc15.src.rpm |
Summary|"Review request: arista - An|Review request: arista - An
|easy to use multimedia |easy to use multimedia
|transcoder for the GNOME |transcoder for the GNOME
|Desktop |Desktop
--- Comment #4 from Nicolas Chauvet <kwizart(a)gmail.com> 2011-10-09 12:49:03 ---
SPEC: http://deogracia.free.fr/RPMS/arista.spec
SRPM: http://deogracia.free.fr/RPMS/arista-0.9.7-2.fc15.src.rpm
Summary: An easy to use multimedia transcoder for the GNOME Desktop
Thx for your submission
For forgot to mention why this package cannot be in fedora ?
I expect it will be because of the gstreamer-ffmpeg and others requirements,
but please remind that adding gstreamer-plugins-bad-nonfree will make this
package fall into the nonfree section.
For the same reason that we should avoid package in the nonfree section, I
think this package should also be eligible for fedora by removing some explicit
requirements.
This need to be tested in order to prove a basic usability such as transcoding
from theora to webm, but also to fail with a message telling the user that some
codec are missing (and eventually to install them if the RPM Fusion repository
is installed).
Other comments:
- Please use english for comments
- duplicate license field for the subpackage:
License: LGPLv2+
The main and subpackage use the same license, please keep only the main license
field.
- CFLAGS="$RPM_OPT_FLAGS" %{__python} for noarch package is not needed, please
remove.
- BR on fdupes is dubious. Files listed twice in a spec file are detected
automatically nowadays. I don't see the point of this check.
Also as the macro doesn't even exist , it should probably be conditionalised:
%{?fdupes:%fdupes %{buildroot}%{_datadir}/arista/}
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
12:04 p.m.
New subject: [Bug 1975] Review request: arista - An easy to use multimedia transcoder for the GNOME Desktop
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1975
--- Comment #5 from Lionel Félicité <deogracia(a)free.fr> 2011-10-09 14:04:14 ---
(In reply to comment #1)
(In reply to comment #0)
> Hi guys!
>
> It's my first rpm.
I see no links to the srpm or spec file.
Hi,
I thought the links were saved when I put them in the URL from field.
So here they are :
http://deogracia.free.fr/RPMS/arista.spec
http://deogracia.free.fr/RPMS/arista-0.9.7-2.fc15.src.rpm
Lionel
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
12:12 p.m.
New subject: [Bug 1975] Review request: arista - An easy to use multimedia transcoder for the GNOME Desktop
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1975
--- Comment #6 from Lionel Félicité <deogracia(a)free.fr> 2011-10-09 14:12:20 ---
Thanks Leigh Scott.
(In reply to comment #3)
Just a few comments
1. it requires nautilus-extensions
2. what propose do these macros serve as there not called
%define python_compile_opt python -O -c "import compileall;
compileall.compile_dir('.')"
%define python_compile python -c "import compileall;
compileall.compile_dir('.')"
I forgot ti remove them. I should have revrite this spec file from sratch. I
just modified the one from mandriva.
https://fedoraproject.org/wiki/Packaging/Python#System_Architecture
It's noarch so opt flags aren't required, use this instead
%build
%{__python} setup.py build
%install
%{__python} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT
3. %fupes is not correct, use fupes instead
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
12:36 p.m.
New subject: [Bug 1975] Review request: arista - An easy to use multimedia transcoder for the GNOME Desktop
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1975
--- Comment #7 from leigh scott <leigh123linux(a)fedoraproject.org> 2011-10-09
14:36:02 ---
(In reply to comment #6)
I forgot ti remove them. I should have revrite this spec file from sratch. I
just modified the one from mandriva.
Install rpmdevtools and run this to generate a spec file
rpmdev-newspec -t python arista
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:32 p.m.
New subject: [Bug 1975] Review request: arista - An easy to use multimedia transcoder for the GNOME Desktop
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1975
--- Comment #8 from Lionel Félicité <deogracia(a)free.fr> 2011-10-22 17:32:15 ---
Hi guys,
I've updated the files.
Could someone check up again please ?
Thanks
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:20 p.m.
New subject: [Bug 1975] Review request: arista - An easy to use multimedia transcoder for the GNOME Desktop
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1975
Richard <hobbes1069(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hobbes1069(a)gmail.com
--- Comment #9 from Richard <hobbes1069(a)gmail.com> 2011-10-22 20:20:44 ---
(In reply to comment #8)
Hi guys,
I've updated the files.
Could someone check up again please ?
Ok, a couple of observations.
1. You only need one of the macros at the top of the spec, whichever is
appropriate. Since your package seems to use pure python module, remove the
sitearch macro.
2. You have the following lines:
# Remove files we install with %%doc
rm -f %{buildroot}%{_datadir}/doc/arista/{AUTHORS,LICENSE,README.md}
But I don't see where in %doc these files are re-added. Admittedly I having
tried building the package but that still looks strange.
It's better to use a packaging trick I learned. At the end of install do
something like this:
# Move documentation so it can be installed in the right place
rm -rf _tmpdoc && mkdir _tmpdoc
mv %{buildroot}%{_datadir}/doc/%{name}/* _tmpdoc/
Then in %files update your %doc to:
%doc _tmpdoc/*
3. Remove "rm -rf $RPM_BUILD_ROOT" in %install as it is no longer needed.
Remove %defattr in %files as it is no longer needed.
4. Don't mix $RPM_BUILD_ROOT and %{buildroot}. Pick one. I like %{buildroot}
but the only requirement is you stick with one or the other.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:08 p.m.
New subject: [Bug 1975] Review request: arista - An easy to use multimedia transcoder for the GNOME Desktop
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1975
--- Comment #10 from leigh scott <leigh123linux(a)fedoraproject.org> 2011-10-22
22:08:51 ---
The macros are obsolete since F12 and can be removed unless you intend to build
for EL5
https://fedoraproject.org/wiki/Packaging/Python#Macros
Also it's no arch so remove the flags
%build
# Remove CFLAGS=... for noarch packages (unneeded)
CFLAGS="$RPM_OPT_FLAGS" %{__python} setup.py build
to
%build
%{__python} setup.py build
You can also remove this from both files sections
%defattr(-,root,root,-)
https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4779
days inactive
4793
days old
rpmfusion-developers@lists.rpmfusion.org
10 comments
1 participants
participants (1)
-
RPM Fusion Bugzilla