[Bug 828] New: Review Request: omnibook-kmod - Kernel module for HP Omnibook/Pavillon, Toshiba Satellite and Compal laptops
11:28 a.m.
http://bugzilla.rpmfusion.org/show_bug.cgi?id=828
Summary: Review Request: omnibook-kmod - Kernel module for HP
Omnibook/Pavillon, Toshiba Satellite and Compal laptops
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: rpm(a)greysector.net
CC: rpmfusion-package-review(a)rpmfusion.org
Blocks: 2
Estimated Hours: 0.0
Spec URL:http://rathann.fedorapeople.org/review/omnibook-kmod.spec
SRPM
URL:http://rathann.fedorapeople.org/review/omnibook-kmod-2.20090714-0.1.s...
Description:
Linux kernel module for many HP Omnibook/Pavillon, Toshiba Satellite
(with Phoenix BIOS) and Compal laptops. It is based on the module found
in the 'omke' project.
And the -common package:
Spec URL:http://rathann.fedorapeople.org/review/omnibook-kmod-common.spec
SRPM
URL:http://rathann.fedorapeople.org/review/omnibook-kmod-common-2.2009071...
rpmlint output:
kmod-omnibook.x86_64: W: no-documentation
kmod-omnibook-2.6.30.5-43.fc11.x86_64.x86_64: W: summary-not-capitalized
omnibook kernel module(s) for 2.6.30.5-43.fc11.x86_64
kmod-omnibook-2.6.30.5-43.fc11.x86_64.x86_64: W: unstripped-binary-or-object
/lib/modules/2.6.30.5-43.fc11.x86_64/extra/omnibook/omnibook.ko
kmod-omnibook-2.6.30.5-43.fc11.x86_64.x86_64: W: no-documentation
6 packages and 0 specfiles checked; 0 errors, 4 warnings.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:28 p.m.
New subject: [Bug 828] Review Request: omnibook-kmod - Kernel module for HP Omnibook/Pavillon, Toshiba Satellite and Compal laptops
http://bugzilla.rpmfusion.org/show_bug.cgi?id=828
Julian Sikorski <belegdol(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |belegdol(a)gmail.com
--- Comment #1 from Julian Sikorski <belegdol(a)gmail.com> 2009-09-21 01:28:04 ---
I'd be very happy to see this in the repos. Unfortunately, I have never
reviewed a kmod before. Is there anything I should particularly look at?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:54 p.m.
New subject: [Bug 828] Review Request: omnibook-kmod - Kernel module for HP Omnibook/Pavillon, Toshiba Satellite and Compal laptops
http://bugzilla.rpmfusion.org/show_bug.cgi?id=828
--- Comment #2 from Julian Sikorski <belegdol(a)gmail.com> 2009-09-21 01:54:13 ---
1. If I understand the guidelines correctly, the common package should rather
be called just “omnibook” and provide omnibook-kmod-common.
2. Does this make sense:
BuildArch: noarch
# needed for plague to make sure it builds for i586 and i686
ExclusiveArch: i586 i686 x86_64 ?
Other than these two, it mostly seems to be fine, as compared with the
template.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:15 a.m.
New subject: [Bug 828] Review Request: omnibook-kmod - Kernel module for HP Omnibook/Pavillon, Toshiba Satellite and Compal laptops
http://bugzilla.rpmfusion.org/show_bug.cgi?id=828
--- Comment #3 from Julian Sikorski <belegdol(a)gmail.com> 2009-09-21 10:15:14 ---
Created an attachment (id=292)
--> (http://bugzilla.rpmfusion.org/attachment.cgi?id=292)
build log
Seems that I was right, the -common package fails to build:
Executing command: ['bash', '--login', '-c', 'rpmbuild -bb
--target x86_64
--nodeps builddir/build/SPECS/omnibook-kmod-common.spec']
error: Architecture is not included: noarch
Building target platforms: x86_64
Building for target x86_64
Child returncode was: 1
EXCEPTION: Command failed. See logs for output.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:04 a.m.
New subject: [Bug 828] Review Request: omnibook-kmod - Kernel module for HP Omnibook/Pavillon, Toshiba Satellite and Compal laptops
http://bugzilla.rpmfusion.org/show_bug.cgi?id=828
--- Comment #4 from Dominik 'Rathann' Mierzejewski <rpm(a)greysector.net>
2009-11-16 02:04:36 ---
Fixed common package (hopefully).
Spec URL:http://rathann.fedorapeople.org/review/omnibook.spec
SRPM
URL:http://rathann.fedorapeople.org/review/omnibook-2.20090714-0.2.svn288...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:14 a.m.
New subject: [Bug 828] Review Request: omnibook-kmod - Kernel module for HP Omnibook/Pavillon, Toshiba Satellite and Compal laptops
http://bugzilla.rpmfusion.org/show_bug.cgi?id=828
--- Comment #5 from Julian Sikorski <belegdol(a)gmail.com> 2009-11-16 02:14:32 ---
The link to SRPM does not work. But I used the new spec to create it myself,
and the package seems to build now.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:29 a.m.
New subject: [Bug 828] Review Request: omnibook-kmod - Kernel module for HP Omnibook/Pavillon, Toshiba Satellite and Compal laptops
http://bugzilla.rpmfusion.org/show_bug.cgi?id=828
--- Comment #6 from Julian Sikorski <belegdol(a)gmail.com> 2009-11-16 02:29:04 ---
Also, there is a weird rm -rf ${RPM_BUILD_ROOT} at the beginning of
kmod-omnibook install stage, which rpmlint complains about. The same error is
present in the template in the wiki.
Other than that, packages seem fine. I'll test them ASAP.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:33 a.m.
New subject: [Bug 828] Review Request: omnibook-kmod - Kernel module for HP Omnibook/Pavillon, Toshiba Satellite and Compal laptops
http://bugzilla.rpmfusion.org/show_bug.cgi?id=828
--- Comment #7 from Julian Sikorski <belegdol(a)gmail.com> 2009-11-16 02:33:55 ---
One more: perhaps a buildroot cleanup would be nice for omnibook install
section as well?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:08 a.m.
New subject: [Bug 828] Review Request: omnibook-kmod - Kernel module for HP Omnibook/Pavillon, Toshiba Satellite and Compal laptops
http://bugzilla.rpmfusion.org/show_bug.cgi?id=828
--- Comment #8 from Dominik 'Rathann' Mierzejewski <rpm(a)greysector.net>
2009-11-16 03:08:54 ---
(In reply to comment #7)
One more: perhaps a buildroot cleanup would be nice for omnibook
install
section as well?
It doesn't build if it's there (try and see!). And since nothing is getting
installed in %install, I think it's safe to leave it out. Especially since
current rpm's %install macro does rm -rf %{buildroot} automatically anyway.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:12 a.m.
New subject: [Bug 828] Review Request: omnibook-kmod - Kernel module for HP Omnibook/Pavillon, Toshiba Satellite and Compal laptops
http://bugzilla.rpmfusion.org/show_bug.cgi?id=828
Julian Sikorski <belegdol(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|2 |4
Status|NEW |ASSIGNED
--- Comment #9 from Julian Sikorski <belegdol(a)gmail.com> 2009-11-16 03:12:09 ---
OK, agreed. I'm working on a patch which will allow for detection of my laptop
(satellite a100), but I'm having some issues. It can be added after import,
though.
This package is approved.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:57 p.m.
New subject: [Bug 828] Review Request: omnibook-kmod - Kernel module for HP Omnibook/Pavillon, Toshiba Satellite and Compal laptops
http://bugzilla.rpmfusion.org/show_bug.cgi?id=828
Dominik 'Rathann' Mierzejewski <rpm(a)greysector.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |33
--- Comment #10 from Dominik 'Rathann' Mierzejewski <rpm(a)greysector.net>
2009-11-27 21:57:29 ---
Package CVS request
======================
Package Name: omnibook
Short Description: Common files for omnibook-kmod
Owners: rathann
Branches: F-12 F-11
InitialCC:
----------------------
License tag: free
Package CVS request
======================
Package Name: omnibook-kmod
Short Description: Kernel module for HP Omnibook/Pavillon, Toshiba Satellite
and Compal laptops
Owners: rathann
Branches: F-12 F-11
InitialCC:
----------------------
License tag: free
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:33 p.m.
New subject: [Bug 828] Review Request: omnibook-kmod - Kernel module for HP Omnibook/Pavillon, Toshiba Satellite and Compal laptops
On Friday, 27 November 2009 at 21:57, RPM Fusion Bugzilla wrote:
Could someone with CVS admin access handle this request?
Regards,
R.
--
Fedora http://fedoraproject.org/wiki/User:Rathann
RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu
"Faith manages."
-- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"
9:07 p.m.
New subject: [Bug 828] Review Request: omnibook-kmod - Kernel module for HP Omnibook/Pavillon, Toshiba Satellite and Compal laptops
http://bugzilla.rpmfusion.org/show_bug.cgi?id=828
--- Comment #11 from Dominik 'Rathann' Mierzejewski <rpm(a)greysector.net>
2009-11-27 22:06:59 ---
Correct URLs:
SPEC: http://rathann.fedorapeople.org/review/omnibook.spec
SRPM:
http://rathann.fedorapeople.org/review/omnibook-2.20090714-0.1.svn288.fc1...
SPEC: http://rathann.fedorapeople.org/review/omnibook-kmod.spec
SRPM:
http://rathann.fedorapeople.org/review/omnibook-kmod-2.20090714-0.1.svn28...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:02 p.m.
New subject: [Bug 828] Review Request: omnibook-kmod - Kernel module for HP Omnibook/Pavillon, Toshiba Satellite and Compal laptops
http://bugzilla.rpmfusion.org/show_bug.cgi?id=828
--- Comment #12 from Wojciech "McMonster" Pisarski <mcmonster(a)o2.pl>
2009-11-27 23:02:57 ---
Created an attachment (id=318)
--> (http://bugzilla.rpmfusion.org/attachment.cgi?id=318)
dmesg output when loading omnibook
For Toshiba Satellite A300-1EG changing LCD brightness using Fn+F6/F7 still
doesn't work. Brightness applet or gnome-power-manager are unable to control
brightness, can manually set it using /proc/acpi/video/VGA/LCD/brightness.
This feature worked on Ubuntu 8.04-9.10 with omnibook module installed from
source http://packages.kirya.net/debian/pool/main/o/omnibook/ using
module-assistant.
Attached dmesg output.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:57 p.m.
New subject: [Bug 828] Review Request: omnibook-kmod - Kernel module for HP Omnibook/Pavillon, Toshiba Satellite and Compal laptops
http://bugzilla.rpmfusion.org/show_bug.cgi?id=828
Thorsten Leemhuis <fedora(a)leemhuis.info> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|33 |
--- Comment #13 from Thorsten Leemhuis <fedora(a)leemhuis.info> 2009-12-14 19:57:55
---
(In reply to comment #10)
Package CVS request
done
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
12:18 p.m.
New subject: [Bug 828] Review Request: omnibook-kmod - Kernel module for HP Omnibook/Pavillon, Toshiba Satellite and Compal laptops
http://bugzilla.rpmfusion.org/show_bug.cgi?id=828
--- Comment #14 from Dominik 'Rathann' Mierzejewski <rpm(a)greysector.net>
2010-01-16 13:18:51 ---
Built for F-11 and F-12. Could someone help with the rawhide build? I don't
understand why it's failing.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
5:16 p.m.
New subject: [Bug 828] Review Request: omnibook-kmod - Kernel module for HP Omnibook/Pavillon, Toshiba Satellite and Compal laptops
http://bugzilla.rpmfusion.org/show_bug.cgi?id=828
Dominik 'Rathann' Mierzejewski <rpm(a)greysector.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #15 from Dominik 'Rathann' Mierzejewski <rpm(a)greysector.net>
2010-05-07 19:16:50 ---
All branches seem to be building now, so close.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
5313
days inactive
5542
days old
rpmfusion-developers@lists.rpmfusion.org
16 comments
2 participants
participants (2)
-
Dominik 'Rathann' Mierzejewski -
RPM Fusion Bugzilla