commit ba112033d49124d719ec38a7e360308acf579a2a Author: Nicolas Chauvet <kwizart(a)gmail.com&gt; Date: Thu Apr 4 18:27:12 2019 +0200 Add more check_mode: no playbooks/manual/update-firmware.yml | 10 +++++----- roles/fedmsg/base/tasks/main.yml | 2 +- roles/mirrormanager/mirrorlist2/tasks/main.yml | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) --- diff --git a/playbooks/manual/update-firmware.yml b/playbooks/manual/update-firmware.yml index a065fc1..301880a 100644 --- a/playbooks/manual/update-firmware.yml +++ b/playbooks/manual/update-firmware.yml @@ -49,13 +49,13 @@ tasks: - name: Create drop place for upgrades - always_run: true + check_mode: no when: ansible_virtualization_role == "host" file: path=/root/firmware-upgrades state=directory - name: Check which updates to copy - always_run: true + check_mode: no stat: path=/root/firmware-upgrades/{{ item.1}}.applied register: is_applied_results when: item.0.vendor == ansible_system_vendor and item.0.product == ansible_product_name @@ -64,7 +64,7 @@ - files - name: Copy updates - always_run: true + check_mode: no copy: src={{ bigfiles }}/firmware/{{ item.item.0.dirname }}/{{ item.item.1}} dest=/root/firmware-upgrades/ mode=0700 @@ -75,7 +75,7 @@ # Dell updates here - name: Check Dell updates - always_run: true + check_mode: no command: /root/firmware-upgrades/{{ item.item.1}} -qc register: check_results failed_when: "'System(s) supported by this package' in check_results.stdout" @@ -105,7 +105,7 @@ # We are cleaning up all files we copied, regardless of update result - name: Delete update files - always_run: true + check_mode: no file: path=/root/firmware-upgrades/{{ item.item.1 }} state=absent when: "'stat' in item and not item.stat.exists" diff --git a/roles/fedmsg/base/tasks/main.yml b/roles/fedmsg/base/tasks/main.yml index bf00ac6..5eaa2ef 100644 --- a/roles/fedmsg/base/tasks/main.yml +++ b/roles/fedmsg/base/tasks/main.yml @@ -322,7 +322,7 @@ - name: Check if the nrpe user exists shell: /usr/bin/getent passwd nrpe | /usr/bin/wc -l | tr -d ' ' register: nrpe_exists - always_run: true + check_mode: no changed_when: "1 != 1" tags: - fedmsg/base diff --git a/roles/mirrormanager/mirrorlist2/tasks/main.yml b/roles/mirrormanager/mirrorlist2/tasks/main.yml index 8bf8e89..a8145a3 100644 --- a/roles/mirrormanager/mirrorlist2/tasks/main.yml +++ b/roles/mirrormanager/mirrorlist2/tasks/main.yml @@ -52,7 +52,7 @@ #- name: check to see if its even installed yet # shell: semodule -l | grep mirrorlist2 | wc -l # register: ficgeneral_grep -# always_run: true +# check_mode: no # changed_when: "'0' in ficgeneral_grep.stdout" # tags: # - mirrorlist2