[Bug 126] Review Request: dvdrip - Graphical DVD ripping and encoding tool

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=126





--- Comment #17 from Orcan Ogetbil <orcanbahri at yahoo.com>  2008-12-10 04:14:22 ---
I worked on this package a little more. Here's what I made:
SPEC: http://6mata.com:8014/review/dvdrip.spec
SRPM: http://6mata.com:8014/review/dvdrip-0.98.9-4.fc10.src.rpm

Still the following issues need to be addressed:


> * What is wrong with the parallel make? I'm asking for both C side and perl
> side.


> * These BR's seem unnecessary:
>      BuildRequires: perl(ExtUtils::MakeMaker)
>      BuildRequires: perl(Gtk2) >= 1.081
>      BuildRequires: perl(Locale::TextDomain) >= 1.16
> The first two are pulled up by other ones. The last one isn't used during the
> build, as far as I can tell.
> 
In the above SPEC file I commented out these. Package built fine with
rpmfusion-free enabled mock.


> * %define _default_patch_fuzz 2
> Can't you just provide better patches to eliminate this?
>
The nontplworkaround patch does not apply correctly. It changes things in some
unrelated line. Please see the source files. I don't think we need this patch
at all. In the above SPEC file I commented out this patch, as well as the 
_default_patch_fuzz line since this is the only patch that needs it.


> * Please make a %check section and run the test script.
> 
This does not apply since the test requires a running X.


You can replace my hacks if you don't like them. Also those commented-out lines
can be removed. I just left them for your consideration.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.