[Bug 26] Review request: dvbcut - Clip and convert DVB transport streams to MPEG2 program streams

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=26





--- Comment #17 from David Timms <dtimms at iinet.net.au>  2008-12-16 14:28:57 ---
(In reply to comment #14)
> Some quick notes:
> 
> * Compile process does not use {%optflags}. At least this is what I see when
> compiling the first file because...
> 
> * ...it does not build at least under F9/i386.
Interesting since I have done most of my dev on F8, then F9 i386.

> * You may want to have a look at these patches:
> http://viewcvs.gentoo.org/viewcvs.py/gentoo-x86/media-video/dvbcut/files/
Shall do.

> * Why are packaging an svn snapshot? What are the pro's against latest
> release?
Latest release is 18 months old. As I found bugs, or patches (eg gcc43 warns),
include path changes I was submitting them, and they were being accepted or
alternate fixes incorporated. One item was to do with paths and file names, but
it's all fading from memory now.

> Is this snapshot stable?
I have been using the program as packaged since building it (on F9, i386).

> Is a more recent snapshot better than the one used?
If you think it reasonable, I'll make the adjustments you suggest in the second
half of your notes, leaving it at the same svn revision.

Then I'll update to latest svn. {note that the author(s) made a little noise
about a release about 6 months ago, but nothing has been forthcoming, there
hasn't been much svn activity either.

Third thing and separately, I'll change to building with make, autoconf etc.
This was introduced into svn about june when various users of the package kept
having trouble getting it to build with SCons (along with me). So this will be
quite a change to the spec.

The other thing that's happening is rawhide will soon get a new ffmpeg
apparently, which will probably bust thing up ...

If you were to do full review, would you want to see the intermediate steps, or
just the final converted to be current svn + autotool build changes ?


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.