[Bug 165] Review Request: cmus - Ncurses-Based Music Player

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=165





--- Comment #7 from Andrea Musuruane <musuruan at gmail.com>  2008-12-16 14:51:23 ---
(In reply to comment #6)
> OK, I have incorporated your suggestions into this set of spec/srpm:
> 
> http://konradm.fedorapeople.org/fedora/SPECS/cmus.spec
> http://konradm.fedorapeople.org/fedora/SRPMS/cmus-2.2.0-2.fc9.src.rpm

You still have to resolve this problem:

* There is no compile output. Makefile must be patched to see it. This is a
blocking issue. A reviewer must see the output of what is happening when
building (for example, to see the CFLAGS).

Then:

* use %{name} and %{version} macros here:

Source0:        http://mirror.greaterscope.net/cmus/cmus-%{version}.tar.bz2
Patch0:        
http://ftp.riken.go.jp/Linux/gentoo/media-sound/cmus/files/cmus-2.2.0-new-ffmpeg.patch

Don't use the %{version} macro for the patch though. So you can reuse the same
patch in next releases, if it still applies.

* Do not use full URL for Patch0. This is just a mirror and it is not
guaranteed to work in the future. Just place a note that the patch comes from
Gentoo Bugzilla #218105.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.