[Bug 165] Review Request: cmus - Ncurses-Based Music Player

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=165





--- Comment #13 from Andrea Musuruane <musuruan at gmail.com>  2008-12-17 11:35:00 ---
(In reply to comment #8)
> > * There is no compile output. Makefile must be patched to see it. This is a
> > blocking issue. A reviewer must see the output of what is happening when
> > building (for example, to see the CFLAGS).
> 
> I don't see how this is a blocker nor why it warrants patching the makefile.

Probably we have some kind of misunderstanding Kevin. The makefile suppress the
output when calling many commands including the compiler. In this way neither
the submitter nor the reviewer can see how the files are complied, linked and
so on.

Using %{optflags} is mandatory and with the unpatched upstream makefile there
is no way to check them:
https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.