[Bug 26] Review request: dvbcut - Clip and convert DVB transport streams to MPEG2 program streams

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=26





--- Comment #20 from David Timms <dtimms at iinet.net.au>  2008-12-20 14:31:50 ---
(In reply to comment #19)
> Ping me for reviewing it :)

updated spec:
http://members.iinet.net.au/~timmsy/dvbcut/dvbcut.spec
srpm:
http://members.iinet.net.au/~timmsy/dvbcut/dvbcut-0.5.4-0.11.20081218.fc9.src.rpm

lots o' changes.

$ rpmlint -i /home/davidt/rpmbuild/SRPMS/dvbcut-0.5.4-0.11.20081218.fc9.src.rpm
/home/davidt/rpmbuild/RPMS/i386/dvbcut-0.5.4-0.11.20081218.fc9.i386.rpm
/home/davidt/rpmbuild/RPMS/i386/dvbcut-debuginfo-0.5.4-0.11.20081218.fc9.i386.rpm
dvbcut.src:55: W: rpm-buildroot-usage %build ./configure --libdir=%{_libdir}
--with-ffmpeg=%{_prefix} --with-ffmpeg-include=%{_includedir}/ffmpeg/
--prefix=%{buildroot}%{_prefix}
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it will
break short circuiting.

- not sure how to resolve that - if I remove %{buildroot} from --prefix=, then
it won't install. Reconfigure with that buildroot part during install also
doesn't make a successful build. Need help !


dvbcut.src: W: strange-permission dvbcut-snapshot.sh 0775
A file that you listed to include in your package has strange permissions.
Usually, a file should have 0644 permissions.

- script based on ffmpeg-snapshot script for making a dated svn snapshot
archive. Is it allowed to be in the package ? Can I set it to a-x ?


dvbcut-debuginfo.i386: E: empty-debuginfo-package
This debuginfo package contains no files.  This is often a sign of binaries
being unexpectedly stripped too early during the build, rpmbuild not being
able to strip the binaries, the package actually being a noarch one but
erratically packaged as arch dependent, or something else.  Verify what the
case is, and if there's no way to produce useful debuginfo out of it, disable
creation of the debuginfo package.

- -g is passed as argument to gcc, along with the RPM_OPT_FLAGS, but this seems
to be getting removed. Not sure yet what's causing that.

3 packages and 0 specfiles checked; 1 errors, 2 warnings.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.