[Bug 19] Review request: blcr - Berkeley Lab Checkpoint/Restart for Linux

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=19





--- Comment #17 from Orcan Ogetbil <oget.fedora at gmail.com>  2008-12-22 07:47:28 ---
Almost there. You missed this part:
* The file README.devel is not and should be packaged.

My understanding is, you don't want to completely remove the static library
bits from SPEC. If they are to be included (either disabled or enabled) they
need to obey the guidelines, i.e. they need to go to a -static subpackage.
Please read: 

http://fedoraproject.org/wiki/Packaging/Guidelines#Exclusion_of_Static_Libraries

The way it is right now bothers me. It is disabled in the SPEC, but enabling
them will put the static libraries into the devel package, which is wrong.
Maybe you should extend the if-build_static-clause and define the -static
subpackage inside it. Then if someone wants to build the static bits enabled,
the static libraries will get into the correct subpackage.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.