[Bug 19] Review request: blcr - Berkeley Lab Checkpoint/Restart for Linux

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=19





--- Comment #23 from Neal Becker <ndbecker2 at gmail.com>  2008-12-23 02:46:02 ---
(In reply to comment #21)
> * Package doesn't build with mock. It fails with:
>    Patch #1 (blcr-stackcheck.patch):
>    + /bin/cat /builddir/build/SOURCES/blcr-stackcheck.patch
>    + /usr/bin/patch -s -p0 --fuzz=0
>    + autoreconf --force --install
>    Can't exec "aclocal": Permission denied at /usr/share/autoconf/Autom4te
> FileUtils.pm line 326.
>    autoreconf: failed to run aclocal: Permission denied

OK, fixed.  The patch is requires running reconfigure, so BR automake, libtools

> * Still, the file README.devel is not and should be packaged (in the devel
> subpackage).

I think that's gone, isn't it?

> * The "%if %{build_static}" phrase inside "%files static" must go up, right
> before "%package static". Otherwise when "%{build_static}" is disabled you'll
> get an empty static subpackage.

Done.

> 
> * The commented out parts of the SPEC file need to be removed if there's no
> legitimate reason to keep them. If there's a legitimate reason that should be
> explained within the SPEC file.

Done.

> 
> * No macros with single % in a commented-out part is allowed. Use %%
> 

Done.

http://nbecker.dyndns.org:8080/RPM/blcr.spec
http://nbecker.dyndns.org:8080/RPM/blcr-kmod.spec
http://nbecker.dyndns.org:8080/RPM/blcr-0.8.0-0.1.b5.fc10.src.rpm
http://nbecker.dyndns.org:8080/RPM/blcr-kmod-0.8.0-0.1.b5.fc10.src.rpm


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.