[Bug 26] Review request: dvbcut - Clip and convert DVB transport streams to MPEG2 program streams

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=26


dexter <dex.mbox at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dex.mbox at gmail.com




--- Comment #2 from dexter <dex.mbox at gmail.com>  2008-02-29 18:48:58 ---
(In reply to comment #1)
> I request some assistance with improving the package:
> 
> 1. Since I'm using a post release svn checkout, and the inbuilt ffmpeg is not
> being used {ie linking against ffmpeg bits instead}, should I rm -Rf ffmpeg.src
> before .tar.bz up the source ? This would make the source a lot smaller !
> 
> 2. I have ended up with the i386 binary including two copies of the %doc files.
> If I comment that line out - then I get no doc files at all ! Why ?

I recently built this on F7, the install section looks like this:
%install
rm -rf $RPM_BUILD_ROOT
make install PREFIX=%{_prefix} MANPATH=%{_mandir} \
 DESTDIR=$RPM_BUILD_ROOT FFMPEG=%{_includedir}/ffmpeg

MANPATH=%{_mandir} will do the right thing.

> 3. Building the spec into .src.rpm and .i386.rpm was done on a 386 guest
> virtual machine on fedora-development {up2date 2008-02-08}. A spec I initially
> looked at from packman suggested adjustments are needed for x86_64. Can some
> one confirm build works on that and on ppc archs ?
> 
> 4. While debuginfo is built, installing the -debuginfo rpm, gdb dvcut and run
> shows messages indicating debuginfo can't be found. I had a look through:
> http://fedoraproject.org/wiki/Packaging/Debuginfo
> Did my failed gdb test achiev it's purpose ? Do I need to either fix or remove
> the debuginfo config ?
> 

I also added a patch for debuginfo ie -g switch 

--- SConstruct  2008-02-05 21:07:01.000000000 +0000
+++ SConstruct.new      2008-02-05 22:33:10.000000000 +0000
@@ -45,7 +45,7 @@ if (debug>0):
   env.Append(CCFLAGS=['-g3','-Wall'])
   env.Append(LINKFLAGS=['-g3'])
 else:
-  env.Append(CCFLAGS=['-O3','-Wall'])
+  env.Append(CCFLAGS=['-O3','-Wall','-g'])

 env.Replace(CXXFILESUFFIX=".cpp")

In fact I'll attach the full spec to give you ideas.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.