[Bug 29] Review request: freesci - A portable interpreter for SCI games

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=29


Andrea Musuruane <musuruan at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |musuruan at gmail.com
             Blocks|2                           |3
             Status|NEW                         |ASSIGNED




--- Comment #1 from Andrea Musuruane <musuruan at gmail.com>  2008-07-19 13:11:27 ---
Package Review
==============

Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [!] Package meets the Packaging Guidelines.
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: f9/i386
 [x] Rpmlint output is clean.
 [x] Package is not relocatable.
 [x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
 [!] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [!] License field in the package spec file matches the actual license.
     License type: GPLv2
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
     MD5SUM this package    : b7669c1f1db8b7b19967ed61f103df3a
     MD5SUM upstream package: b7669c1f1db8b7b19967ed61f103df3a
 [x] Package is not known to require ExcludeArch
 [!] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [!] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [-] Package does not contain any libtool archives (.la).
 [!] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: f9/i386
 [?] Package should compile and build into binary rpms on all supported
architectures.
     Tested on:
 [!] Package functions as described.
 [x] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files are correct.
 [-] File based requires are sane.


=== Issues ===
1. As freesci ships icons in the hicolor directory, it should have "Requires:
hicolor-icon-theme"
https://www.redhat.com/archives/fedora-extras-list/2006-September/msg00282.html

2. Duplicate BuildRequires: alsa-lib-devel (by SDL-devel)

3. Doc files are missing: NEWS, THANKS, TODO

4. For new packages vendor should be empty: desktop-file-install  --vendor ""

5. %{_datadir}/games/%{name} in %{_datadir}/games/%{name}/config.template is
not an acceptable directory. 
You should use %{_datadir}/%{name} instead:
http://fedoraproject.org/wiki/SIGs/Games/Packaging

6. I cannot hear no sound running freesci. I get the following error in the
console log:
[SFX] Initialised timer 'sdl-pcm-timer', v0.1
[SND:SDL] Error while opening audio: No available audio device
[SFX] Failed to open PCM device, disabling PCM support
[SFX] Song player 'polled' reported error, disabled
[SFX] No song player found

7. License is GPLv2 and not GPLv2+. Some file are released under "version 2 of
the Licence, or (at your option) any later version" but not all. 

8. Missing BuildRequires: libpng-devel (can be used by sciunpack)

9. Can other target versions (using directfb and libggi) be built at the same
time? If yes, you should provide separate sub-packages for these versions.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.