[Bug 122] Review Request: xorg-x11-drv-nvidia-173xx - NVIDIA's 173xx proprietary display driver for NVIDIA graphic cards

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=122


Stewart Adam <s.adam at diffingo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |s.adam at diffingo.com
             Status|NEW                         |ASSIGNED




--- Comment #1 from Stewart Adam <s.adam at diffingo.com>  2008-11-06 15:35:47 ---
+ source files match upstream
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license text included in package.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in properly.
+ package installs properly.
+ debuginfo package looks complete.
- rpmlint is silent.
--> Lots of output... There are the ones which we can fix easily or that we
can't ignore:
xorg-x11-drv-nvidia-173xx.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/xorg/modules/extensions/nvidia/libglx.so
xorg-x11-drv-nvidia-173xx-devel.x86_64: E: description-line-too-long This
package provides the development files of the xorg-x11-drv-nvidia-173xx
package,
xorg-x11-drv-nvidia-173xx.src: W: strange-permission filter-requires.sh 0775
xorg-x11-drv-nvidia-173xx.src: W: strange-permission
nvidia-173xx-config-display 0775
xorg-x11-drv-nvidia-173xx.src: W: strange-permission nvidia-173xx-init 0775
xorg-x11-drv-nvidia-173xx.src: W: strange-permission nvidia-173xx-README.Fedora
0775
- final provides and requires are sane:
--> -libs is still are providing libGL.so.1() libGLcore.so.1()
--> main package must Requires: livna-config-displa >= 0.0.22, as I will have
to update the MODULE_LIST in livna-config-display and rebuild it before the
initscript will work
--> Although the current package has a circular dependency so it doesn't
matter, rpmfusion-config-display will handle the current situation better so
the -devel package should requires the -libs package, not the main package.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ headers are in a -devel subpackage
+ no pkgconfig files.
+ no libtool .la droppings.
+ desktop files valid and installed properly.

Just to have it on the record, as kwizart and I discussed on IRC the
Provides/Obsoletes for a proper upgrade path from FreshRPMs will be added after
the initial import.

Also, seeing as F10 is almost out I think we can remove the FC5 modprobe.d
stuff. I doubt many FC5 users are still rebuilding this driver from SRPM, and
FC5 has been EOL for a long, long time.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.