[Bug 106] Review Request: nvidia-beta-kmod - NVIDIA's beta display driver kernel module

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=106


Stewart Adam <s.adam at diffingo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




--- Comment #3 from Stewart Adam <s.adam at diffingo.com>  2008-11-06 16:21:26 ---
- source files match upstream
--> We create our own tarballs, OK
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license text included in package.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
- package builds properly.
--> Doesn't work with 2.6.27, but 2.6.26 seems to work fine. A quick google
didn't return any patches, but I'm sure one will turn up soon on nvnews (not a
big deal - this is a beta driver after all. If the user wishes to use the beta
driver, they can continue using the 2.6.26 kernel until nVidia releases a newer
version).
+ package installs properly.
+ debuginfo package looks complete.
- rpmlint is silent.
--> Warnings are OK to ignore
+ final provides and requires are sane:
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.

APPROVED


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.