[Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=163





--- Comment #8 from Andrea Musuruane <musuruan at gmail.com>  2008-11-25 15:00:23 ---
(In reply to comment #7)
> * Each package must consistently use macros, as described in the macros section
> of Packaging Guidelines. There are usages of both %{buildroot} and
> $RPM_BUILD_ROOT; also %{optflags} and $RPM_OPT_FLAGS. Please stick to one
> notation.

Fixed.

> * Please preserve the timestamps of the doc files by using "touch -r file1
> file2" when you are fixing the encoding

Fixed.

> * For the .desktop file:
>   ** Use Name: Gambatte Qt instead of QT

Fixed.

>   ** Please add a Generic Name

GenericName is not required by the Desktop entry specification. Anyway I added
it.

> * About %description. There are a few files compiled in the SDL-package that
> are in C.

Description is taken from the README file and I'm not very keen in changing it.

> ? Any possible (license) issues with the 2 source images you added?

I looked a lot for a Gameboy icon image. Most are unusable because they are
either too big, poorly drown or copyrighted.

The one I used is taken from:
http://modmyi.com/forums/skinning-themes-discussion/17378-gameboy-advance-icon.html

Unluckily there is no statement about its licensing.

> ? What are the 4 exports in the %build section for? Aren't they too many?

They are all required. The first two are needed for libgambatte and
gambatte-sql. The latter two for gambatte-qt.

> ? What is the hwtests directory for? Worth to package?

This directory is only useful for a developer who wants to improve gambatte. It
is not useful for the final user. Therefore I decided not to package it.

> ! You may want to consider adding mime-types for gameboy rom images in the qt
> package (you can use the same icons). Mime-types provide convenience.

There are no standard mime types for gameboy ROM types. 

Moreover, I don't think they are so useful in this particular case because most
of the times ROMs are compressed (in .zip files) and the emulators can directly
open these compressed files.

> ? Can't you just use "%post qt" instead of "%post -n gambatte-qt" ?

Fixed.


Updated package:

http://www.webalice.it/musuruan/RPMS/reviews/gambatte.spec
http://www.webalice.it/musuruan/RPMS/reviews/gambatte-0.4.0-2.fc9.src.rpm

* Tue Nov 25 2008 Andrea Musuruane <musuruan at gmail.com> - 0.4.0-2
- Improved macro usage
- Preserved timestamp of doc files converted to UTF-8
- Cosmetic changes


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.