[Bug 67] Review Request: open-vm-tools - VMware Guest OS Tools

RPM Fusion Bugzilla noreply at rpmfusion.org
Thu Oct 16 20:00:18 CEST 2008


--- Comment #1 from Thorsten Leemhuis <fedora at leemhuis.info>  2008-10-16 20:00:18 ---
Just a note for interested parties: help for reviewing this is highly
appreciated; the kmod stuff is sane apart from the stuff mentioned in the fist
comment below!

No full review yet; just a few comments from the fist quick look at the spec
Normally this is correct:

Requires:  open-vm-tools-kmod >= %{version}
Obsoletes: open-vm-tools-kmod < %{version}
Provides:  open-vm-tools-kmod-common = %{version}

But that won't work here as "Version:" for the foreseeable future likely stays

Thus we need something more in version, otherwise is some cases things might
not work (especially if userland stuff and kmods need to stay in sync). This
could get us out of here:

Version: 0.0.0.%{buildver}

That should do the trick (here and in the kmod package please). Yes, that's not
in line with the Fedora packaging guidelines, but it will do the right thing in
this case, thus I'd say it's the right thing to do.

the macro tname is unneeded (just use "name")

Instead of doing
> cat <<EOF > $RPM_BUILD_ROOT%{_sysconfdir}/sysconfig/mouse
> cat <<EOF >>  $RPM_BUILD_ROOT%{_datadir}/gnome/autostart/vmware-user.desktop
> cat <<EOF > $RPM_BUILD_ROOT%{_datadir}/applications/vmware-toolbox.desktop
> cat <<EOF > $RPM_BUILD_ROOT%{_sysconfdir}/modprobe.d/vmnics
just add proper files as SourceX please

What the heck is this?
> %post
> mkdir -p -m 1777 /tmp/VMwareDnD

Just to make sure: Is this strictly needed to be 4755?
> %attr(4755,root,root) /sbin/mount.vmhgfs

Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the rpmfusion-developers mailing list