rpms/unrar/devel unrar-3.7.8-fixes.patch, NONE, 1.1 unrar.spec, 1.2, 1.3

[Dominik 'Rathann' Mierzejewski]

On Saturday, 25 October 2008 at 23:18, Andreas Thienemann wrote:
> Author: ixs
> 
> Update of /cvs/nonfree/rpms/unrar/devel
> In directory se02.es.rpmfusion.net:/tmp/cvs-serv8202
> 
> Modified Files:
> 	unrar.spec 
> Added Files:
> 	unrar-3.7.8-fixes.patch 
> Log Message:
> * Sat Oct 25 2008 Andreas Thienemann <andreas at bawue.net> - 3.7.8-3
> - Added libunrar sub-packages
> - Clarified license
> - Added unrar robustness patches
> 
> 
> unrar-3.7.8-fixes.patch:
> 
> --- NEW FILE unrar-3.7.8-fixes.patch ---
[...]
> diff -up unrar/extract.cpp.fix unrar/extract.cpp
> --- unrar/extract.cpp.fix	2007-09-10 13:49:28.000000000 +0200
> +++ unrar/extract.cpp	2008-10-25 22:41:06.000000000 +0200
> @@ -311,6 +311,7 @@ bool CmdExtract::ExtractCurrentFile(Comm
>      char CurVolName[NM];
>      strcpy(CurVolName,ArcName);
>  
> +    if(strcmp(ArcName,"")==0) return(false);

Huh? Isn't that the same as:
  +    if(!strlen(ArcName)) return(false);


>      VolNameToFirstName(ArcName,ArcName,(Arc.NewMhd.Flags & MHD_NEWNUMBERING));
>      if (stricomp(ArcName,CurVolName)!=0 && FileExist(ArcName))
>      {
[...]

> Index: unrar.spec
> ===================================================================
> RCS file: /cvs/nonfree/rpms/unrar/devel/unrar.spec,v
> retrieving revision 1.2
> retrieving revision 1.3
> diff -u -r1.2 -r1.3
> --- unrar.spec	25 Jul 2008 06:12:22 -0000	1.2
> +++ unrar.spec	25 Oct 2008 21:18:43 -0000	1.3
> @@ -1,12 +1,16 @@
> +# Might be needed to apply fuzzy patches with recent rpm
> +#%%define _default_patch_fuzz 2
> +

Why? Is it because the debian patch doesn't apply cleanly?

>  Name:           unrar
>  Version:        3.7.8
> -Release:        2%{?dist}
> +Release:        3%{?dist}
>  Summary:        Utility for extracting, testing and viewing RAR archives
> -License:        Freeware
> +License:        Freeware with further limitations

I haven't read the license, but can we actually distribute modified versions?

Regards,
R.

-- 
Fedora http://fedoraproject.org/wiki/User:Rathann
RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu
"Faith manages."
        -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"