[Bug 67] Review Request: open-vm-tools - VMware Guest OS Tools

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=67





--- Comment #13 from Orcan Ogetbil <orcanbahri at yahoo.com>  2008-10-27 20:53:23 ---
I worked on the spec file more:
SPEC: http://6mata.com:8014/review/open-vm-tools.spec
SRPM: http://6mata.com:8014/review/open-vm-tools-0.0.0.123053-6.fc9.src.rpm

* Mon Oct 27 2008 Orcan Ogetbil <orcan [AT] yahoo [DOT] com> 0.0.0.123053-6
- Bugfix: Doesn't build for x86_64. (1)
- Added a devel package containing the header and .so files. (2)
- The shell scripts in %%{_sysconfdir}/vmware-tools/ are now marked
non-%%config.
- Minor SPEC file improvements. (3)

(1) I basically added a * at the end of
   %config(noreplace) %attr(0644,root,root) %{_sysconfdir}/pam.d/vmware-guestd

(2) I made a devel package with the libguestlib.so symlink and all the header
files in the /sourcedir/lib/include directory. There are more header files
around which can be added to the devel package if there's need.

(3) I suppressed some more rpmlint warnings. The current rpmlint output is:

 $ rpmlint  /pub/mock/fedora-9-x86_64/result/open-vm-tools-*
open-vm-tools.x86_64: E: setuid-binary /usr/bin/vmware-user-suid-wrapper root
04755
open-vm-tools.x86_64: E: non-standard-executable-perm
/usr/bin/vmware-user-suid-wrapper 04755
open-vm-tools.x86_64: E: setuid-binary /sbin/mount.vmhgfs root 04755
open-vm-tools.x86_64: E: non-standard-executable-perm /sbin/mount.vmhgfs 04755
open-vm-tools.x86_64: W: obsolete-not-provided open-vm-tools-kmod
open-vm-tools.x86_64: E: binary-or-shlib-defines-rpath
/usr/bin/vmware-toolbox-cmd ['/usr/lib64']
open-vm-tools.x86_64: W: service-default-enabled /etc/init.d/vmware-guestd
open-vm-tools.x86_64: W: no-reload-entry /etc/init.d/vmware-guestd
open-vm-tools.x86_64: W: incoherent-init-script-name vmware-guestd
open-vm-tools-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 5 errors, 5 warnings.

I think the binary-or-shlib-defines-rpath can be fixed with a patch.
As for the obsolete-not-provided open-vm-tools-kmod warning: Is this
   Obsoletes:  open-vm-tools-kmod < %{version}
really necessary?

* Btw, you didn't answer/address my previous question about
vmware-user-suid-wrapper permissions yet.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.