rpms/qmmp-plugins-freeworld/F-9 qmmp-plugins-freeworld.spec, 1.3, 1.4

[Dominik 'Rathann' Mierzejewski]

On Friday, 05 September 2008 at 14:45, Karel Volný wrote:
> Author: kvolny
> 
> Update of /cvs/free/rpms/qmmp-plugins-freeworld/F-9
> In directory se02.es.rpmfusion.net:/tmp/cvs-serv12804
> 
> Modified Files:
> 	qmmp-plugins-freeworld.spec 
> Log Message:
> corrected the ffmpeg version problems, finally
> 
> 
> 
> 
> Index: qmmp-plugins-freeworld.spec
> ===================================================================
> RCS file: /cvs/free/rpms/qmmp-plugins-freeworld/F-9/qmmp-plugins-freeworld.spec,v
> retrieving revision 1.3
> retrieving revision 1.4
> diff -u -r1.3 -r1.4
> --- qmmp-plugins-freeworld.spec	20 Aug 2008 15:09:45 -0000	1.3
> +++ qmmp-plugins-freeworld.spec	5 Sep 2008 12:45:48 -0000	1.4
> @@ -1,6 +1,6 @@
>  Name:		qmmp-plugins-freeworld
>  Version:	0.2.0
> -Release:	5%{?dist}
> +Release:	6%{?dist}
>  Summary:	Plugins for qmmp (Qt-based multimedia player)
>  
>  Group:		Applications/Multimedia
> @@ -13,7 +13,7 @@
>  
>  BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root
>  
> -BuildRequires:	cmake ffmpeg-devel < 0.4.9-0.8 libmad-devel qt-devel >= 4.2
> +BuildRequires:	cmake ffmpeg-devel >= 0.4.9-0.47.20080614 libmad-devel qt-devel >= 4.2

Shouldn't they be comma separated if you specify versions?
And anyway, I prefer one dependency per line. It makes
the diffs cleaner and smaller. I recommend you switch to that
scheme as well.

Regards,
R.

-- 
Fedora http://fedoraproject.org/wiki/User:Rathann
Livna http://rpm.livna.org | MPlayer http://mplayerhq.hu
"Faith manages."
        -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"