[Bug 48] Review Request: freej - a vision mixer for video DJs on Linux

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=48





--- Comment #3 from Kevin Kofler <kevin.kofler at chello.at>  2008-09-23 02:36:31 ---
> FreeJ has a built in javascript interpreter.  rpmlint is not intelligent
> enough to realize this.

No, it's trying to tell you that the #! line is wrong. It should say
/usr/bin/freej, not /usr/local/bin/freej, or you should remove the #! line
entirely, which will also get you rid of the "non-executable script" warning.
The #! line is only used when you execute the script directly on the command
line, it makes no sense to have a #! line in a script which doesn't have the +x
flag set, nor does it make sense to have one pointing to a nonexistent path. If
it makes no sense to run the script from the command line, just remove the #!
line, if it _does_ make sense to do that, fix the #! line and set the +x flag.

> The rest is a silly warning.

No, none of the messages are "silly warnings". I already explained how to fix
the .js-related ones above. For the others:

> freej.i386: W: executable-stack /usr/bin/freej

This means that the executable will cause problems with SELinux and is also a
security problem. It is probably due to assembly source files (.s or .S files)
without a GNU-stack note. See:
http://cvs.fedoraproject.org/viewvc/rpms/qimageblitz/devel/qimageblitz-0.0.4-noexecstack.patch?revision=1.1&view=markup
for how to fix such assembly files.

It may also be due to abuse of nested functions in C code, but that's less
likely.

> freej.spec:97: W: macro-in-%changelog __make

You must escape any percent signs in the changelog, e.g. use %%__make instead
of just %_make. Otherwise, the macro will be expanded into the changelog, which
is almost certainly not what you want.

Please fix the issues reported by rpmlint, they're all valid issues and the
package should not be approved without those issues fixed.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.