[Bug 440] Review request: vbam - Nintendo Gameboy, Gameboy Color, and Gameboy Advance Emulator

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=440


Orcan Ogetbil <oget.fedora at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oget.fedora at gmail.com




--- Comment #11 from Orcan Ogetbil <oget.fedora at gmail.com>  2009-04-03 07:26:52 ---
Here are my notes for this package:

* There are many files in the source which are GPLv2 (no later). But there are
also GPLv2+ and LGPLv2+ files.
So it looks like the License field should be
License: GPLv2 and GPLv2+ and LGPLv2+

But apart from these, this one file:
   src/filters/2xSaImmx.asm
has a different license. I don't know what it should be called. Let's research.

! Not a blocker, but this line
   gzip -9 < debian/vbam.1 > %{buildroot}%{_mandir}/man1/vbam.1.gz
is not really necessary. You can install the file via "install -pm 644 ..." and
rpmbuild will take care of the rest.

* Package does not build on rawhide! gcc-4.4 issue:
   /builddir/build/BUILD/vbam-1.8.0/src/sdl/debugger.cpp:948: error: invalid
conversion from 'const char*' to 'char*'

Please patch this up and inform upstream.

* The package must be named according to the Package Naming Guidelines. Is the
project named vbam or vba-m?

* You need to pass VERBOSE=1 to make

* Requires: hicolor-icon-theme is not necessary since it will be in the
dependency chain. (rpmbuild will automatically create library dependencies,
gtk2, libglade etc, and they will pull hicolor-icon-theme)

* We prefer %defattr(-,root,root,-). Also the two %attr(755,root,root) can be
removed.

* You only use %{name} in URL and everywhere else you use vbam. Actually, it is
the other way around. Please make use of the %{name} and %{version} macros
extensively, except possibly in URLs.

* Package does not honor Fedora specific flags. Please see:
   http://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags
Replacing "cmake" with the "%cmake" macro may or may not solve the issue. I
didn't check. But using %cmake is a good practice anyway.

You can check Fedora specific flags via
   rpm -E %optflags

* Please preserve the time-stamps of the non compiled files. For instance, you
can use:
   sed 's/\r//' doc/License.txt > tmpfile
   touch -r doc/License.txt tmpfile
   mv -f tmpfile doc/License.txt



Please let me know if you have any questions/comments/objections.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.