[Bug 440] Review request: vbam - Nintendo Gameboy, Gameboy Color, and Gameboy Advance Emulator

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=440





--- Comment #16 from Dave Straub <dave at is1337.net>  2009-04-06 15:35:15 ---
(In reply to comment #15)
> Actually, it should be enough to add -DBUILD_SHARED_LIBS:BOOL=OFF to %cmake .
> No need to add a patch for this purpose. 
> 
> Let's wait for the upstream's response (but it doesn't look like they intend to
> make these libraries shared).

Alright, I added the overriding flag and removed the patch for CMakeLists.txt.

> By the way, make sure that the Fedora specific optflags are passed. They are
> not honored in the above package either.

They should be. Run `rpm -E %cmake` or `cat /etc/rpm/macros.cmake`.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.