[Bug 547] review request: LCD patches from Ubuntu finally in Fedora

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=547





--- Comment #10 from Kevin Kofler <kevin.kofler at chello.at>  2009-04-15 11:07:31 ---
Your fontconfig has 2 relevant patches:
> Patch2: 04_ubuntu_monospace_lcd_filter_conf.patch
> Patch5: 06_ubuntu_lcddefault.patch
(There's also the 05_lcdfilterlegacy.patch, but all that does is accept
lcdfilterlegacy as an alias for lcdlegacy in the config files, I don't see why
we need or want that at all.)

Both those patches just add fontconfig .conf files. Those files could be added
to freetype-freeworld instead, or maybe even to the Fedora fontconfig (I think
the options will be ignored if subpixel rendering is disabled), in any case it
makes no sense to ship a fontconfig-freeworld package for those (especially not
one which overrides the library, as these changes are only to the config file).

So to sum up your review requests:
* freetype-lcd: not needed, all relevant patches are in freetype-freeworld
* cairo-lcd, libXft-lcd: one relevant patch (the others should be dropped and
the Fedora patches used instead) and I really don't see why that cannot go into
Fedora instead. Please get those 2 patches (1 per package) accepted by upstream
and by the Fedora maintainers, pointing out they actually REMOVE potentially
patented code and leave it up to freetype whether to provide it or not (and
Fedora's freetype doesn't).
* fontconfig-lcd: the config files from the patches 04 and 06 should be
provided by freetype-freeworld instead, fontconfig-lcd should be dropped
entirely


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.