[Bug 459] Review request: nvidia-cuda-toolkit - NVIDIA CUDA Toolkit libraries

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=459





--- Comment #6 from NicolasChauvet <kwizart at gmail.com>  2009-04-15 12:09:33 ---
I don't know where you got the cudatoolkit initscript but it is totally undeed.
Once the nvidia driver is loaded, the /dev/nvidia? and /dev/nvidiactl are
automatically created. Furthermore this script assume the module name to be
hardcoded to nvidia.ko which won't be garanted in the near future for all
nvidia driver branches (even only cuda capables branches).

Once the initscript is removed, please only update the spec file as the src.rpm
is quite big.

- License:
The License is nVidia proprietary, and can be redistributed according to :
quoting EULA.txt
"2.1.2 Linux/FreeBSD Exception. Notwithstanding the foregoing terms of Section
2.1.1, SOFTWARE designed exclusively for use on the Linux or FreeBSD operating
systems, or other operating systems derived from the source code to these
operating systems, may be copied and redistributed, provided that the binary
files thereof are not modified in any way (except for unzipping of compressed
files). "
So this pretty well fit with our:
Redistributable, no modification permitted

- You need a ExclusiveArch since cudatoolkit is only provided as i386 i586
x86_64
That will lead to have:
%if 0%{?fedora} > 10
ExclusiveArch:  i586 x86_64
%else
ExclusiveArch:  i386 x86_64
%endif

- Please use the full source url when possible for SOURCE0/1

- cuda virtual provides can probably be versioned (version-release.)


- Post scripts, since libraries are provided by the -libs sub-package, you need
to have:
%postun libs -p /sbin/ldconfig

- According to the cuda download page. The cudatoolkit highly depend on a
certified nvidia driver version. (specially for EL-5, where they are multiple
version). I can bump the nvidia driver to that version, but i guess that once
cuda 2.2 will be here, It will be possible to have two differents certified
cuda version on a Fedora 9 plateform. 
That will lead to work with alternative, so different version of the
cudatoolkit can co-exist. (like there is with different version of the jdk
compiler).
(I don't like to use version in the name of the package )

- It would be better to fix the package in %prep (iconv, sed, etc)
and then to cp -pR the whole directories to a versioned prefix in %install
(like /usr/lib/cudatoolkit-%{version}-%{_target_cpu} which is the best suitable
for compiler according to the FHS )

Then everything could be versioned as appropriate using alternative in %post
%postun .

But this probably needs more experiments (what is the default installation
prefix btw ?)



Whatever the decision to use a better prefix, I don't like cuda headers to be
available in the standard include path. This could be tweaked from
/usr/bin/nvcc.profile.
On the other side, I will probably introduce pkg-config support for cudart.pc
provided within the nvidia driver.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.