[Bug 459] Review request: cudatoolkit - NVIDIA CUDA Toolkit

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=459


Milos Jakubicek <xjakub at fi.muni.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|kwizart at gmail.com           |rpmfusion-package-
                   |                            |review at rpmfusion.org
             Status|ASSIGNED                    |NEW




--- Comment #8 from Milos Jakubicek <xjakub at fi.muni.cz>  2009-04-18 01:34:12 ---
(In reply to comment #6)
> I don't know where you got the cudatoolkit initscript but it is totally undeed.
> Once the nvidia driver is loaded, the /dev/nvidia? and /dev/nvidiactl are
> automatically created. Furthermore this script assume the module name to be
> hardcoded to nvidia.ko which won't be garanted in the near future for all
> nvidia driver branches (even only cuda capables branches).

Well, I found the info about it on NVidia website ("might be necessary") and it
was present in the Mandriva package. Unfortunately I don't have any
CUDA-enabled GPU card available (...in fact, I've no Nvidia around at all, just
realizing:), hence I'm sorry but I couldn't test. I have one tester among
Fedoras BOINC users who however is not able to find out such things of course.

> 
> - You need a ExclusiveArch since cudatoolkit is only provided as i386 i586
> x86_64
> That will lead to have:
> %if 0%{?fedora} > 10
> ExclusiveArch:  i586 x86_64
> %else
> ExclusiveArch:  i386 x86_64
> %endif

Done.

> - Please use the full source url when possible for SOURCE0/1

Done, sorry, I thought there is no direct link, but finally I found one indeed.

> - cuda virtual provides can probably be versioned (version-release.)

Done.

> - Post scripts, since libraries are provided by the -libs sub-package, you need
> to have:
> %postun libs -p /sbin/ldconfig

Done.

> - According to the cuda download page. The cudatoolkit highly depend on a
> certified nvidia driver version. (specially for EL-5, where they are multiple
> version). I can bump the nvidia driver to that version, but i guess that once
> cuda 2.2 will be here, It will be possible to have two differents certified
> cuda version on a Fedora 9 plateform. 
> That will lead to work with alternative, so different version of the
> cudatoolkit can co-exist. (like there is with different version of the jdk
> compiler).
> (I don't like to use version in the name of the package )

Done too, hope in the right way.

> - It would be better to fix the package in %prep (iconv, sed, etc)
> and then to cp -pR the whole directories to a versioned prefix in %install
> (like /usr/lib/cudatoolkit-%{version}-%{_target_cpu} which is the best suitable
> for compiler according to the FHS )

Done.

> But this probably needs more experiments (what is the default installation
> prefix btw ?)

> Whatever the decision to use a better prefix, I don't like cuda headers to be
> available in the standard include path. This could be tweaked from
> /usr/bin/nvcc.profile.

I used %{_includedir}/cudart which is one of the upstream solutions. 

Updated SPEC file as previously on:
http://mjakubicek.fedorapeople.org/nvidia-cuda-toolkit/cudatoolkit.spec


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.