[Bug 476] Review request: blender-freeworld - Additional parts of blender not distributed in Fedora

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=476





--- Comment #9 from Jochen Schmitt <Jochen at herr-schmitt.de>  2009-04-20 18:44:42 ---
(In reply to comment #7)
> (In reply to comment #5)
> > * This macro seems not to be used:
> > 
> > %define blend blender-freeworld
> > 
> > * In this macro blender-nonfree needs to be changed to blender-freeworld:
> > 
> > %define plugins %{_libdir}/blender-nonfree/plugins
> > 
> > It would be easier to use the name macro in this way:
> > 
> > %define plugins %{_libdir}/%{name}/plugins
> This is not as easy, so I tend to disagree, this content from blender-nonfree
> shoudln't override the content fromm blender itself. so for some part, it
> should use the blender compiled shared object.
> 
> This is a dumb assumption at this time as I've just look at the spec file
> itself.

Please be aware, that the access to the diretories whill be come from
~/.blender/plugins. This directories contains symlinks which are created from
the blender wrapper script and point to the shared objects in
%{_libdir}/%{name}/plugins.

> Use libGL-devel and libGLU-devel instead of harcoded mesa vendor ones.

This is a good idea.

> - I never understood why ${RPM_BUILD_ROOT}/%{_bindir} was used instead of
> $RPM_BUILD_ROOT%{_bindir}; but this is trivial. (and also more aesthetic: it
> suggest that you know that %{_bindir} already have a "/" at the beginning).

Bad habit.

> BTW, - You need to remove the x264 sources along with ffmpeg ones from the
> fedora source archive.

Done.

> - Are you sure to have solve the problem with the blender binary/noarch script
> directory (where blender plugins will store their content and temporary files)?

Should be fixed.

Next Release:
SPEC: http://www.herr-schmitt.de/pub/blender-freeworld/blender-freeworld.spec
SRPM:
http://www.herr-schmitt.de/pub/blender-freeworld/blender-freeworld-2.48a-3.fc10.src.rpm


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.