[Bug 441] Review request: traverso - Multitrack Audio Recording and Editing Suite

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=441





--- Comment #12 from Orcan Ogetbil <oget.fedora at gmail.com>  2009-04-27 02:39:53 ---
kwizart, sorry I was away for a little. I'll answer your questions here:

> %ifarch %{ix86}
>          -DCMAKE_CXX_FLAGS:STRING="${CXXFLAGS}         \
> this "sounds" weird
> you are using a %{cmake} macro, so it shoudn't be necessary
> or the usual way to pass this is to use RPM_OPT_FLAGS, which should be 
> passed in ppc/ppc64 also

%cmake macro doesn't define CMAKE_CXX_FLAGS. But the CMakelist file uses
CMAKE_CXX_FLAGS instead of just CXXFLAGS. That's why I have to set
CMAKE_CXX_FLAGS to CXXFLAGS.


> isn't -DHOST_SUPPORTS_SSE=TRUE -DIS_ARCH_X86_64=TRUE  enough instead of 
> tweaking the CXXFLAGS ?

Looking at the code, I found that this is the only way of getting things
compiled. Remove any of them and you will see what happens.

Yes, the upstream CMakelist file is a little non-standard.


> oget, is it possible to tweak the docdir with cmake instead of the hack you 
> are using ?
> you should be able to (the same there is the autotools --docdir directory)

The CMakelist file foes not support it. @DOC_FILE@ is something that I have
introduced by hand so that the program will guide Fedora users to the right
documentation for setting up the /etc/security/limits.conf file. It's not a bad
hack (check the patch traverso-warnings.patch).


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.