[Bug 751] Review request: vboxgtk - A simple GTK frontend for VirtualBox

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=751


Lubomir Rintel <lkundrak at v3.sk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|2                           |4




--- Comment #9 from Lubomir Rintel <lkundrak at v3.sk>  2009-08-11 11:55:58 ---
Seems good now you can proceed requesting CVS,

APPROVED
========

Anyway, just a few comments:

1.) Requires:       python-VirtualBox-OSE >= 2.2.2

This probably does not have to be versioned

2.) BuildArch:      noarch

On the second thought, this might be a problem, since plague (the build system)
would build this for PowerPC as well and therefore would cause a package with
unsatisfied dependencies to be in repositories. (I am not completely sure
though, what does the review list think about this?) You may have to change
that to something like the following (that is actually just a workaround for
weird plague behaviour), though the package is in fact noarch:

%if 0%{?fedora} > 11
ExclusiveArch:  i686 x86_64
%else %if 0%{?fedora} > 10
ExclusiveArch:  i586 x86_64
%else
ExclusiveArch:  i386 x86_64
%endif


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.