[Bug 393] Package review - perl-IP-Country - Fast lookup of country codes from IP addresses

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=393


Paul Howarth <paul at city-fan.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul at city-fan.org
             Blocks|                            |3
              Alias|                            |perl-IP-Country
             Status|NEW                         |ASSIGNED




--- Comment #1 from Paul Howarth <paul at city-fan.org>  2009-02-26 00:09:49 ---
A few initial comments:

 * The %files section for the -utils subpackage needs a %defattr

 * There are lots of "dot files" in the distribution that look to me to be
MacOS resource forks; I suspect they could be removed in %prep without any
detriment to the package.

 * Is a separate -utils package really justified? It's substantially smaller
than the main package and only pulls in one more additional dependency
(perl-Geography-Countries) which itself is a small module.

Generally looks like a regular perl module package so it should be an easy
review.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.