[Bug 269] Review Request: snowballz - a fun RTS game featuring snowball fights with penguins

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=269





--- Comment #3 from Orcan Ogetbil <oget.fedora at gmail.com>  2009-01-10 16:03:26 ---
(In reply to comment #1)
[...]
> Are these zero length files required for snowballz to work ?
> 
Afaict yes. Removing them makes the game misbehave. I wonder why this didn't
show up when I ran rpmlint the first time.

>   - is it normal to stick games in ../games/%{name} ? (Well I see fortune and
> torcs are, and frozen-bubble isn't so I guess I answered that.)
I think it's OK. This is the first game I ever packaged though. I'm open to
suggestions.

> [! ] Summary:        A fun RTS game featuring snowball fights with penguins
>   - It might be worth expanding RTS into what it means (for those that don't
> know), 
> 
> [!] desktop files has been created. It uses a "beta" trailer in the title,
> which is useful to inform players that there could be problems in the game.
>   The groups meet freedesktop standard, as required.
>   - GenericName=RTS Game
> Maybe: Graphical Real Time Strategy Game 
done

>   - Comment=Command your army of penguins
> Maybe: A game where you command an army of penguins
> 
Isn't it obvious that it is a "game"? Also, we already used the word "game" in
the Generic Name section. What's your opinion?

> [! ] license "GPLv2+ and MIT": the only licensing I can see is in:
> snowui/__init__.py
> but it isn't a well known license. Why did you select these as the license ?
> 
It is MIT, Modern Style with sublicense (see
https://fedoraproject.org/wiki/Licensing/MIT)
I should remove the GPLv2+ since I removed that font (which is GPLv2+).
Done.

> [??] in setup, ttf fonts are removed. Would it be better to remove them
> (TSCu_Comic.ttf) in the snapshot creation process, so that they don't make it
> into the .src.rpm ?
>     This might make it more difficult once there are release source archives.
>     Is the reason to remove it because it's license is unclear ? A comment to
> describe why would help readers.
>     Do you need to (somehow) replace the font with font already in Fedora ? 
> 
Inclusion of fonts in non-font packages is forbidden in Fedora now. I worked on
packaging this font separately. After some consultations to the fonts guys in
Fedora and Debian, we figured that this font is incomplete and has a wrong
table, and hence we shouldn't package it in Fedora as is. I worked on it
further. I corrected the table and added more characters. Here's the project
I've been working on: 
   http://serafettin.sourceforge.net/
I will package this for Fedora at some point.

The font is not used in the program. I believe it is because the game is in the
production stage. It may be used later when the stable version comes up. Then
we can replace it with some other font from Fedora.

I'm removing the font during the snapshot creation process now.

> [??] no scriptlets
>     why would you build the wrapper script during setup, rather than separately
> storing the script in cvs ? 
>     Would it be better to be able to keep the creation time from cvs ?
> 
I guess you're right. Changed.

> [! ] waiting on Requires: pyglet to be able to install built package and test
> functionality.
> ====
> Needs work, and or brief spec file comments for some choices youhave made, in
> my opinion, and waiting on other reviews.
> 

Let me know about the Comment in the .desktop file. Here are the latest files:
SPEC: http://oget.fedorapeople.org/review/snowballz.spec
SRPM:
http://oget.fedorapeople.org/review/snowballz-1.0-0.2.beta1.20090110hg.fc10.src.rpm

Thanks again, for the review.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.