[Bug 25] truecrypt - Cross Platform Disk Encryption Software

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=25





--- Comment #23 from leigh scott <leigh123linux at fedoraproject.org>  2009-07-03 21:22:24 ---
(In reply to comment #22)
> - source files match upstream: a17b9236a3b7b506d78fef20726294679d0a8c3f vs
> 0aef417dc3caf449be6117258eac1644fccec9e3
> --> Please rename Source: to Source0:
> + package meets naming and versioning guidelines.
> + specfile is properly named, is cleanly written and uses macros consistently.
> + dist tag is present.
> + build root is correct.
> + license field matches the actual license.
> ? license is open source-compatible.
> There are two parts of the license that worry me:
> -->"Modification" means (and "modify" refers to) any alteration of This
> Product, including, [...] repackaging [...]
> --> The name of ([...] modified version of This Product) must not contain the
> name TrueCrypt [...] nor any other names confusingly similar to the name
> TrueCrypt
> 
> Perhaps we should to contact them just to be sure? Apart from this, license
> seems to be OK for redistribution and open source (but I'm not a lawyer)
> +license text included in package.
> +latest version is being packaged.
> +BuildRequires are proper.
> + compiler flags are appropriate.
> + %clean is present.
> + package installs properly.
> + debuginfo package looks complete.
> - rpmlint is silent.
> truecrypt.x86_64: W: invalid-license TrueCrypt License Version 2.7
> --> This is OK; TrueCrypt license isnt' recognized by rpmlint
> truecrypt.x86_64: W: unstripped-binary-or-object /usr/sbin/truecrypt
> --> We may wish to strip this or create a debuginfo package.
> + final provides and requires are sane
> + no shared libraries are added to the regular linker search paths.
> + doesn't own any directories it shouldn't.
> + no duplicates in %files.
> + file permissions are appropriate.
> + no scriptlets present.
> + code, not content.
> + documentation is small, so no -docs subpackage is necessary.
> + %docs are not necessary for the proper functioning of the package.
> + no headers.
> + no pkgconfig files.
> + no libtool .la droppings.
> + desktop files valid and installed properly.
> 
> The desktop file is valid, but has two warnings:
> - /usr/share/applications/truecrypt.desktop: warning: key "Encoding" in group
> "Desktop Entry" is deprecated
> - /usr/share/applications/truecrypt.desktop: warning: value
> "System;Application;" for key "Categories" in group "Desktop Entry" contains a
> deprecated value "Application"
> 
> Consider removing Application and Encoding from the desktop.
> 

Hi stewart,

I am not getting the unstripped-binary-or-object warning here with the package
built at Koji.

http://koji.fedoraproject.org/koji/taskinfo?taskID=1453086

[leigh at localhost Desktop]$ rpmlint truecrypt-6.2a-3.fc11.x86_64.rpm
truecrypt.x86_64: W: invalid-license TrueCrypt License Version 2.7
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
[leigh at localhost Desktop]$


Would this be better?


[Desktop Entry]
Type=Application
Exec=truecrypt
Icon=truecrypt
Comment=On-the-fly encryption
Terminal=false
Name=TrueCrypt
StartupNotify=true
Categories=System;


Thanks

Leigh


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.