[Bug 310] scid - A chess database application

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=310





--- Comment #21 from Orcan Ogetbil <oget.fedora at gmail.com>  2009-06-17 22:01:20 ---
(In reply to comment #18)
> I wrote two patches scid-makefile-togaII.patch and
> scid-makefile-phalanx.patch. Actually I don't like the way I fix optflags
> issues. Could you recommend a better way?
> 

I think this is the best we could do. You could ask upstream why they are not
honoring the flags defined by OPTIMIZE variable for the compilation of these
files.

> > * Also please include the doc files in src/egtb/ in %doc
> Is it really necessary? These files are useful only for developers.
> 

I think that you are right. These are the only documentation regarding
Nalimov's code but they are not meant to be useful by end users. I leave the
inclusion of these documents up to you.

> 
> > * The final license tag will then be something like
> >    License: GPLv2+ and freely redistributable and distributable only in Scid
> > Also please explain briefly with comments next to the license tag what files
> > belong to each group.
> Is it necessary to specify license tag for subpackages?
> 

Actually, this is a good question and something that I missed during the
review. The license tag is inherited from the parent package. You only have to
define the license tag in a subpackage if it is different from the parent's. 

Now, correct me if I'm wrong: In this case,
- the main package is "GPLv2+ and distributable only in Scid"
- sounds and bases packages are "GPLv2+"
- books package is "GPL+ and freely distributable"

Please verify the GPL versions above and update the license tags accordingly.

(In reply to comment #20)
> > * There are a few compilation warnings of type
> >    src/egtb/tbindex.cpp:1204: warning: format '%d' expects type 'int', but
> > argument 2 has type 'size_t'
> > Please fix them as they might cause problems in 64bit systems. (Replacing 
> > %d by %zd should solve it) 
> Done. (I managed to reproduce it only on 64bit machine.)
> 

Thanks! This patch is upstreamable.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.