[Bug 679] Review request: HandBrake - Multithreaded DVD to MPEG-4 converter

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=679





--- Comment #2 from Bernard Johnson <bjohnson at symetrix.com>  2009-06-24 01:10:08 ---
(In reply to comment #1)
> There is one major issue with this package:

Understood, which is why I pointed it out.  The libraries in rpmfusion are too
old or do not contain the needed patches.  You absolutely can not build against
the current rpmfusion versions as they are too old.

If you study the work that I've done, I'm managed to unbundle the majority of
this to external packages.  I've also taken ownership of one (libmkv) into
Fedora.

More details here:
http://lists.rpmfusion.org/pipermail/rpmfusion-developers/2009-March/004433.html

> There are also other issues like
> 
> * Instead of doing
>    mv $RPM_BUILD_ROOT/%{_prefix}/local/bin/* $RPM_BUILD_ROOT/%{_bindir}/
> you need to set the prefix during building
> 
> * Use the latest scriptlets
>    http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
> 
> * No more --vendor="fedora" in new packages
> 

This is now resolved.

SPEC: http://www.symetrix.com/~bjohnson/projects/rpmfusion/HandBrake.spec
SRPM:
http://www.symetrix.com/~bjohnson/projects/rpmfusion/HandBrake-0.9.3-2.fc11.src.rpm


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.