[Bug 414] Review request: motion - Motion, a Video-surveilance-system

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=414


rc040203 at freenet.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203 at freenet.de




--- Comment #1 from rc040203 at freenet.de  2009-03-03 13:05:12 ---
Some comments (This is not a formal review):


* Package doesn't build due to a missing
Please add
BuildRequires: zlib-devel


* Directories 
/usr/share/motion-3.2.11
and 
/usr/share/motion-3.2.11/examples
are unowned


* Compilation issues a serious warning:
...
gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m64 -mtune=generic -D_REENTRANT -DHAVE_FFMPEG
-I/usr/include/ffmpeg -DFFMPEG_NEW_INCLUDE
S -DHAVE_FFMPEG_NEW -DMOTION_V4L2 -DTYPE_32BIT="int" -DHAVE_BSWAP    -Wall
-DVERSION=\"3.2.11\" -Dsysconfdir=\"/etc/motion\"    -c -o video.o video.c
In function 'strncat',
    inlined from 'v4l_open_vidpipe' at video.c:507:
/usr/include/bits/string3.h:153: warning: call to __builtin___strncat_chk might
overflow destination buffer


* configure tries to apply build-host cpu-specific CFLAGS. This doesn't make
sense in distributed rpms.
=> Please add --without-optimizecpu to %configure to disable this behavior


* Your %preun etc. scriptlets do not comply to 
https://fedoraproject.org/wiki/Packaging/SysVInitScript

Please use absolute paths to the tools being used inside of the scriptlets,
%preun lacks the "if [ $1 = 0 ] ; then .. fi" guard.

Also worth consideration (if applicable) is adding a %postun scriptlet similar
to this:
if [ "$1" -ge "1" ]; then
    /sbin/service motion condrestart >/dev/null 2>&1
fi


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.