[Bug 247] Review Request: mac - Monkey's Audio Codec (MAC) utility and library

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=247





--- Comment #15 from Orcan Ogetbil <oget.fedora at gmail.com>  2009-03-13 15:30:33 ---
* %ifarch i686 x86_64
   BuildRequires:  yasm
   %endif
Shouldn't we add i586 ?

* %description says:
  "Permission to redistribute is granted by the AUTHOR to rpmfusion.org only.
  See mac-permission_to_redistribute.txt"

But mac-permission_to_redistribute.txt is not included in the final binary RPM.

* Package fails to build in rawhide:

 g++ -DHAVE_CONFIG_H -I. -I. -I../../src/Shared -I../../src/Shared -O2 -g -pipe
-Wall -Wp,-D_FORTIFY_\
SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64
-mtune=generic -MT APEInfo.lo \
-MD -MP -MF .deps/APEInfo.Tpo -c APEInfo.cpp  -fPIC -DPIC -o .libs/APEInfo.o
APELink.cpp: In member function 'void CAPELink::ParseData(const char*, const
str_utf16*)':
APELink.cpp:66: error: invalid conversion from 'const char*' to 'char*'
APELink.cpp:67: error: invalid conversion from 'const char*' to 'char*'
APELink.cpp:68: error: invalid conversion from 'const char*' to 'char*'
APELink.cpp:69: error: invalid conversion from 'const char*' to 'char*'
make[3]: *** [APELink.lo] Error 1

* Finally, one can just install the package "mac-libs", without installing the
packages "mac" and "mac-devel". But then he/she will not see the license text
of the package because the license file is not in the "mac-libs" package. Shall
we include the src/License.htm file and mac-permission_to_redistribute.txt in
the mac-libs package?


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.