[Bug 436] Review request: Moonlight - Moonlight is an open source implementation of Microsoft Silverlight for Unix systems

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=436





--- Comment #3 from Kevin Kofler <kevin.kofler at chello.at>  2009-03-15 01:59:51 ---
> I think the legal and political concerns the Fedora project has relating to
> this package are still relevant to RPM Fusion, and thus I'm opposed to this
> being included here. But that is just my opinion.

Well, RPM Fusion ships other patent-encumbered stuff as well (ffmpeg etc.), so
I don't think it makes sense to reject this based on being patent-encumbered.
The patents happen to be held by M$, but so are the ClearType patents
freetype-freeworld is allegedly infringing.

While I hate Silverlight, Moonlight and the Novell-M$ pact, I don't think it's
fair to reject this package from RPM Fusion.

> Please include [...] why this package is not allowed in Fedora.

I'll fill that one in:
https://fedoraproject.org/wiki/ForbiddenItems#Moonlight


As for the package itself, some observations (not a formal or complete review):
* 0%{?fedora_version} is not defined in Fedora or RPM Fusion. This is a macro
specific to the openSUSE Build Service. Please use 0%{?fedora} instead.
Likewise, 0%{rhel_version} should be changed to 0%{?rhel}. (And checks like %if
0%{?fedora} || 0%{?rhel_version} are redundant and can be removed altogether,
RPM Fusion packages are not going to be built on anything else.)
* A general observation related to the above: it is in general not a good idea
to reuse specfiles from openSUSE (or Mandriva, for that matter), they have very
different packaging conventions from ours.
* The "Authors: ..." block should be removed from %description (also an
openSUSE-ism?).
* Please remove the 0%{suse_version} conditionals.
* Why is this overriding __find_provides and __find_requires?
* Why are you disabling ffmpeg support?


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.