[Bug 414] Review request: motion - Motion, a Video-surveilance-system

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=414


Stewart Adam <s.adam at diffingo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |s.adam at diffingo.com
             Status|NEW                         |ASSIGNED




--- Comment #6 from Stewart Adam <s.adam at diffingo.com>  2009-03-15 17:11:27 ---
I'll take this review.

+ source files match upstream: bc171b1fa6c6a1a72f7fa3eecea2396fdcb8a02c
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+ license field matches the actual license and license is open
source-compatible. License text included in package.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package installs properly.
+ debuginfo package looks complete.
+ rpmlint is silent.

- final provides and requires are sane: Is the hard requirement on ffmpeg
needed?
# rpm -q --requires motion
...
libavcodec.so.51()(64bit)  
libavformat.so.52()(64bit)
...
# rpm -q --whatprovides 'libavformat.so.52()(64bit)'
'libavcodec.so.51()(64bit)'
ffmpeg-libs-0.4.9-0.55.20080908.fc10.x86_64
ffmpeg-libs-0.4.9-0.55.20080908.fc10.x86_64
Unless motion makes direct calls to ffmpeg, ffplay or ffserver on the command
line, the autorequirement on ffmpeg-libs is fine.

+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ scriptlets are present, but comply to the guidelines
+ documentation is small, so no -docs subpackage is necessary. %docs are not
necessary for the proper functioning of the package.
+ no headers., pkgconfig files or libtool *.la files.

Some other things that need to be fixed:
* Comment out the sql_* directives as they are unrecognized without SQL support
compiled-in:
[0] Unknown config option "sql_log_image"
[0] Unknown config option "sql_log_snapshot"
[0] Unknown config option "sql_log_mpeg"
[0] Unknown config option "sql_log_timelapse"
[0] Unknown config option "sql_query"

* Modify the initscript so that it checks if motion is already running

Minor issues - not strictly necessary, but please consider:
* Suppressing motion's output when runing 'service motion start', as this will
appear each startup:
Starting motion: [0] Processing thread 0 - config file /etc/motion/motion.conf
[0] Motion 3.2.11 Started
[0] Motion going to daemon mode

* Removing "Motion, " from the summary field as it is redundant. Also, Video
does not need a capital letter.

* Replacing the distributed initscript with your own (or patching the existing
one) to be LSB compliant (see
https://fedoraproject.org/wiki/Packaging/SysVInitScript#LSB_Header_Example)

* Reformatting the desecription so that it is the closes possible to the
80-character limit:
 %description
Motion is a software motion detector. It grabs images from video4linux devices
and/or from webcams (such as the axis network cameras). Motion is the perfect
tool for keeping an eye on your property keeping only those images that are
interesting. Motion is strictly command line driven and can run as a daemon
with a rather small footprint. This version is built with ffmpeg support but
without MySQL and PostgreSQL support.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.