[Bug 441] Review request: traverso - Multitrack Audio Recording and Editing Suite

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=441


NicolasChauvet <kwizart at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kwizart at gmail.com
         AssignedTo|rpmfusion-package-          |kwizart at gmail.com
                   |review at rpmfusion.org        |




--- Comment #1 from NicolasChauvet <kwizart at gmail.com>  2009-03-16 15:00:13 ---
- ASM been enabled from builder capabilities.
I've compiled the package for x86_64 and it uses -m3dnow (my CPU is an AMD
4200+). So I expect it will lead to problem while 3dnow isn't available on a
given x86_64 system. The same problem would be expected for x86.

While keeping sse asm optim for x86_64 is acceptable, this could lead to
problem on x86 and it will override our RPM_OPT_FLAGS ( by -m3dnow -march=i686
-msse -mfpmath=sse )

maybe building mode should be tweaked

- Pulseaudio isn't selected by default on my system (while PA user daemon is
running and works fine). Either the sound server detection mechanism needs to
be improved to detect the SS at runtime, either you need to tweak the default
sound output to PA.

- SLV2 support          :       TRUE (Using internal library)
Is this library mature enough to be submitted for review externally

- Desktop file validation:
+ desktop-file-install --dir
/builddir/build/BUILDROOT/traverso-0.49.0-1.i386/usr/share/applications
--remove-category=Application resources/traverso.desktop
resources/traverso.desktop: key "MimeType" is a list and does not have a
semicolon as trailing character, fixing

- Just an open question: This package could submitted in Fedora once mp3
support is removed. What to do if it is the case ? (since we don't override
Fedora packages).


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.