[Bug 440] Review request: vbam - Nintendo Gameboy, Gameboy Color, and Gameboy Advance Emulator

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=440





--- Comment #6 from Andrea Musuruane <musuruan at gmail.com>  2009-03-16 21:01:52 ---
(In reply to comment #5)
> The revision number was specified as outlined here:
> https://fedoraproject.org/wiki/Packaging/NamingGuidelines#SnapshotPackages
> I added the svn comment above the Source tag rather than a wget at the top.

I suggest you to use the same versioning in the tarball (i.e.
%{name}-%{version}-%{releasetag}.tar.gz), instead of using %{name}.tar.gz.

> > * Some BR are not required:
> > https://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2
> 
> They were specified more to remind myself I need them when using a live CD to
> test a clean build. I removed them if they are troublesome to include.

Yes, you must remove them.

You also must remove duplicate BR: glibmm24-devel (by gtkmm24-devel),
gtkmm24-devel (by gtkglextmm-devel)

> Updated SRPM:
> http://dave.is1337.net/sources/vbam-1.8.0-0.2.20090316svn856.fc10.src.rpm

SRPM is 0 bytes.



-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.