[Bug 436] Review request: Moonlight - Moonlight is an open source implementation of Microsoft Silverlight for Unix systems

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=436





--- Comment #18 from Andrea Musuruane <musuruan at gmail.com>  2009-03-17 16:34:14 ---
Some comments:

* Summary can be better. E.g. "An open source implementation of Silverlight".

* I would also remove every reference to Novell. Is that really useful? Even
the Moonlight page at http://www.mono-project.com/Moonlight doesn't call this
product "Novell Moonlight" but simply "Moonlight".

* The buildroot is not correct:
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

* Do we really want so much conditionals? For example, I would expect that
pulseaudio is always in since it is the default Fedora sound server.

* Summary and Description for libs package should be different than the one
used in the main package.

* Are these Susisms?

%{?env_options}
%{?configure_options}
[..]
%{__make} %{?jobs:-j%jobs}

I think the last one should be 
make %{?_smp_mflags}

* %makeinstall macro should not be used:
https://fedoraproject.org/wiki/Packaging:Guidelines#Why_the_.25makeinstall_macro_should_not_be_used


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.