[Bug 563] Review request: xorg-x11-drv-catalyst - AMD's proprietary driver for ATI graphic cards

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=563





--- Comment #9 from Stewart Adam <s.adam at diffingo.com>  2009-05-03 18:59:37 ---
(In reply to comment #8)
> I cannot test until monday, but i't rather good, so still few minor comments:
> - Requires(post):  ldconfig is undeeded since we use %post libs -p /sbin/ldconfig
Fixed, moved the Requires(post) to the libs package

> - Requires(post):  catalyst-kmod >= %{version} - IS this needed ?, Requires is
> already set, everything which isn't mandatory should be avoided to prevent
> weird effect or case corner at the rpm transaction check while updating the
> driver.
> ( in theory it should only be:  "Requires:  catalyst-kmod = %{version}" ).
I removed this - I don't see why this is here either, the removal order in
terms of the main package and the kmod package doesn't matter at all, as long
as they are removed together it is OK.

> - This one is more important and was missing: (for the main package).
> Requires:        %{name}-libs-%{_target_cpu} = %{version}-%{release}
> the requirement for the libs subpackage must be architecture dependant.
Fixed

> - Are you really sure that all files in /etc should be set as %config ?!
> (In reply to comment #3)
>> 8* %config need to be appended for earch file using /etc
I interpreted this as %config was needed for every file... I've removed %config
from the following files:
%{_sysconfdir}/ati/atiogl.xml
--> Unclear on how this file is used, so have the driver always replace it on
upgrades to ensure proper functioning. Apparently contains profiles for various
applications...
%{_sysconfdir}/ati/logo.xbm.example
%{_sysconfdir}/ati/logo_mask.xbm.example
--> These files are just logos, no need for %config.
%{_sysconfdir}/ati/amdpcsdb.default
--> This file contains the default values/tweaks for amdcccle and aticonfig.
Should be replaced every update.
%{_sysconfdir}/ati/signature
%{_sysconfdir}/ati/control
--> These files control hardware verification: They should be replaced upon
every driver update to ensure that the driver can verify hardware correctly.

> - #ExclusiveArch:   x86_64 i586
> We talk about that previously, use the same tweak as the nvidia driver, less
> problem...
Fixed

SPEC: http://downloads.diffingo.com/rpmfusion/xorg-x11-drv-catalyst.spec
SRPM:
http://downloads.diffingo.com/rpmfusion/xorg-x11-drv-catalyst-9.4-4.fc10.src.rpm


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.