[Bug 985] Review request: ProjectX-0.90.4.00-2
RPM Fusion Bugzilla
noreply at rpmfusion.org
Mon Nov 30 13:01:41 CET 2009
http://bugzilla.rpmfusion.org/show_bug.cgi?id=985
David Timms <dtimms at iinet.net.au> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dtimms at iinet.net.au
Status|NEW |ASSIGNED
--- Comment #1 from David Timms <dtimms at iinet.net.au> 2009-11-30 13:01:41 ---
I'll take first look; it's my first java review (go easy) ;-)
Summary:
I think this could be expanded a bit: perhaps:
DVB mpg stream analysis, demultiplex and repair tool
Patch:
should that be %{name}...
BuildRequires / Requires:
I'd prefer to see at least the minimal build/requires on separate lines. This
makes it easier to see that the package guidelines are being met, and when
adjustments are needed, the diff from a previous version becomes clearer.
%global
not sure what that is or does. Can you please explain ?
%description
DVB is also used in other countries, eg Australia, so I'm not sure mentioning
only Europe is important. Eg maybe "Europe and many countries...
It would also be good to spell out the Digital Video Broadcasting before use of
the acronym.
Also, I think we aren't really looking at the transmissions themselves, but
rather mpeg transport streams that DVB tuner device has decoded.
%build
Is there any standard ways of doing stuff in:
http://fedoraproject.org/wiki/Packaging:Java#build-classpath
that would make sense to use with this package ?
install & clean
rm -rf %buildroot
Is that supposed to be %{ } for most of the %xyz items.
It would be clearer to create the install script as a file that goes into cvs,
rather than create it during the build.
%files
why does %{bindir}/projectx need specific attribs set ?
%changelog
Please fix the typo in the date and preparation
build process:
I noticed two things while failing to build the package:
1. yum-builddep on .src:
Installing:
jakarta-commons-net noarch 2.0-2.fc12 fedora 187 k
jakarta-oro i686 2.0.8-6.3.fc12 fedora 170 k
java-1.5.0-gcj-devel i686 1.5.0.0-29.fc12 fedora 45 k
recode i686 3.6-28.fc12 fedora 636 k
Installing for dependencies:
ecj i686 1:3.4.2-6.fc12 fedora 2.4 M
gcc-java i686 4.4.2-7.fc12 fedora 3.3 M
libgcj-devel i686 4.4.2-7.fc12 fedora 1.6 M
libgcj-src i686 4.4.2-7.fc12 fedora 12 M
Transaction Summary
================================================================================
Install 8 Package(s)
Upgrade 0 Package(s)
Total download size: 21 M
Is this ok [y/N]: y
Downloading Packages:
Setting up and reading Presto delta metadata
Processing delta metadata
Package(s) data still to download: 21 M
(1/8): ecj-3.4.2-6.fc12.i686.rpm | 2.4 MB 00:05
(2/8): gcc-java-4.4.2-7.fc12.i686.rpm | 3.3 MB 00:03
(3/8): jakarta-commons-net-2.0-2.fc12.noarch.rpm | 187 kB 00:00
(4/8): jakarta-oro-2.0.8-6.3.fc12.i686.rpm | 170 kB 00:00
(5/8): java-1.5.0-gcj-devel-1.5.0.0-29.fc12.i686.rpm | 45 kB 00:00
(6/8): libgcj-devel-4.4.2-7.fc12.i686.rpm | 1.6 MB 00:01
(7/8): libgcj-src-4.4.2-7.fc12.i686.rpm | 12 MB 00:19
(8/8): recode-3.6-28.fc12.i686.rpm | 636 kB 00:00
--------------------------------------------------------------------------------
Total 526 kB/s | 21 MB 00:39
Running rpm_check_debug
Running Transaction Test
Finished Transaction Test
Transaction Test Succeeded
Running Transaction
Installing : 1:ecj-3.4.2-6.fc12.i686 1/8
Installing : jakarta-oro-2.0.8-6.3.fc12.i686 2/8
Installing : recode-3.6-28.fc12.i686 3/8
Installing : libgcj-devel-4.4.2-7.fc12.i686 4/8
Installing : libgcj-src-4.4.2-7.fc12.i686 5/8
Installing : jakarta-commons-net-2.0-2.fc12.noarch 6/8
Installing : gcc-java-4.4.2-7.fc12.i686 7/8
Installing : java-1.5.0-gcj-devel-1.5.0.0-29.fc12.i686 8/8
failed to read link /usr/bin/javac: No such file or directory
failed to read link /usr/lib/jvm/java-gcj: No such file or directory
failed to read link /usr/lib/jvm/java-1.5.0: No such file or directory
Installed:
jakarta-commons-net.noarch 0:2.0-2.fc12 jakarta-oro.i686 0:2.0.8-6.3.fc12
java-1.5.0-gcj-devel.i686 0:1.5.0.0-29.fc12 recode.i686 0:3.6-28.fc12
Dependency Installed:
ecj.i686 1:3.4.2-6.fc12 gcc-java.i686 0:4.4.2-7.fc12
libgcj-devel.i686 0:4.4.2-7.fc12 libgcj-src.i686 0:4.4.2-7.fc12
Complete!
----
not sure if the failed to read link stuff is important.
2. rpmbuild -ba .spec:
+ cd ProjectX_Source_0.90.4
+ /bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ echo 'Patch (ProjectX.sysjava.patch):'
Patch (ProjectX.sysjava.patch):
+ /bin/cat /home/davidt/rpmbuild/SOURCES/ProjectX.sysjava.patch
+ /usr/bin/patch -s -p0 --fuzz=0
+ exit 0
Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.VKoNfM
+ umask 022
+ cd /home/davidt/rpmbuild/BUILD
+ cd ProjectX_Source_0.90.4
+ LANG=C
+ export LANG
+ unset DISPLAY
+ sed -i '/Class-Path/I d' MANIFEST.MF
+ sh build.sh
build.sh: line 13: javac: command not found
build.sh: line 15: jar: command not found
error: Bad exit status from /var/tmp/rpm-tmp.VKoNfM (%build)
RPM build errors:
Bad exit status from /var/tmp/rpm-tmp.VKoNfM (%build)
=====
So the question is:
Do I need to configure alternatives to set a preferred javac jar ?
And if so, how would this work on the build system, where we don't have the
ability to manually set such things ?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
More information about the rpmfusion-developers
mailing list