[Bug 985] Review request: ProjectX-0.90.4.00-2

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=985





--- Comment #5 from Göran Uddeborg <goeran at uddeborg.se>  2009-11-30 22:33:30 ---
Thanks for all the feedback!

(In reply to comment #1)

I'll update the description and formatting of BuildRequires according to your
suggestions, and fix the typos.

>   %global
> not sure what that is or does. Can you please explain ?

%global is much like %define, and is the form the packaging guidelines
prescribe:
http://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define

> Is there any standard ways of doing stuff in:
> http://fedoraproject.org/wiki/Packaging:Java#build-classpath

I'm patching the build script already, so I could probably patch it in a
different way to use build-classpath instead.

> rm -rf %buildroot
> Is that supposed to be %{ } for most of the %xyz items.

Are the curly braces mandatory?  I thought that was just different styles,
where both were acceptable.  Like choosing between %buildroot versus
$RPM_BUILD_ROOT.  (Or %{buildroot} versus ${RPM_BUILD_ROOT}. :-)

> It would be clearer to create the install script as a file that goes into cvs,
> rather than create it during the build.

That I don't understand.  The build script is part of the source zip file.  How
do you mean "create it during the build"?

> why does %{bindir}/projectx need specific attribs set ?

Since I just create it in the %install section, it does not get executable bits
on by default.  I could add them with a chmod command, but I thought I could
just as well just specify them.

>   Installing     : java-1.5.0-gcj-devel-1.5.0.0-29.fc12.i686                8/8 
> failed to read link /usr/bin/javac: No such file or directory
> failed to read link /usr/lib/jvm/java-gcj: No such file or directory
> failed to read link /usr/lib/jvm/java-1.5.0: No such file or directory

That looks like a bug in the java-1.5.0-gcj-devel package.  Possibly triggered
by some kind of inconsistent state when you started.  But I don't know why that
would happen.  It shouldn't.


(In reply to comment #2)
> Is there anything in the mandriva spec that applies to fedora ?

I'll take a look and compare.

> , it is pretty old though.

So is ProjectX. :-)  It's not very actively developed.  But still quite useful.

> They have included a desktop file, so I'm guessing it's a gui app and hence
> needs a destop file in Fedora / RPM Fusion.

Ah, right, I forgot about that!  I've only been using it as a command line tool
myself, so I didn't think about it.  But it can indeed run in graphical mode
too, so I'll add that.


(In reply to comment #3)
> It seems that you are using lib supplied with the sources and not system ones.

Do I?  The sources does indeed come with precompiled jar files.  But I don't
think I'm using them.  Avoiding it is the reason I patch the build script. 
(Though I could probably patch in a better way, as mentioned above.)  Do I miss
something? 


(In reply to comment #4)
> Also please consider adding the GCJ AOT bits to the package, as requested in
> java packaging guidelines:

I see now I misunderstood the section on GCJ in the Java guidelines.  It just
says "Please refer to Packaging/GCJGuidelines for GCJ-specific guidelines".  I
interpreted that as "Refer to Packaging/GCJGuidelines if you use GCJ".  And
until now I've been using openJDK, so I thought that didn't apply to me.  I
didn't realize GCJ was compulsory.

Again, thanks for all the feedback!  I'll be back with an improved version in a
little while.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.