[Bug 802] Review request: openafs - Enterprise Network File System

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=802





--- Comment #16 from Jack Neely <jjneely at ncsu.edu>  2009-10-14 00:42:04 ---
(In reply to comment #15)

> Bad:
> - Don't make a build with bundled libraries. Please remove
>   the bundled libraries and make a build agains the 
>   existing system libaries

What libraries are you referring to?  The libafs* libraries are part of OpenAFS
and not system libraries.

> - Please use %{_sysconfdir} instead of /etc

Fixed.

> - Build didn't hournour the $RPM_OPT_FLGS during the build

Fixed.

> - make haven't %{?_smp_mflags}. If the build is not SMP compilant
>   please at a comment and open a upstream bug report

Alas, the build isn't SMP compliant. 

Filed: http://rt.central.org/rt/index.html?q=125489

> - It's not recommented to use the %makeinstall macro.

Fixed.

> - Package don't contains verbatin copy of the license text. 
>   Please contact upstream to include one. (No Blocker)

/usr/share/doc/openafs-1.4.11/LICENSE is provided by the main package.  Does it
need to be included in all the sub packages?

I do adjust it to be UTF-8 encoded.  Otherwise this generates an rpmlint
warning.

> - Please fix the knewn rpmlint issues.

The libraries call exit().  I can't fix this because I believe it will cause
more confusion and breakage than leaving it as is.  This will have to be
handled upstream.

http://rt.central.org/rt/Ticket/Display.html?id=125490

Filed a bug for the executable stack as well.

http://rt.central.org/rt/Ticket/Display.html?id=125491

Issues with /var/cache/openafs are no longer relevant.  The package is
configured to use the memcache option so the on disk cache directory is not
needed and has been removed.

What documentation needs to go in the sub packages?

> - Please add a ChangeLog entry for each new release

Fixed.

> - Package should not contains static libraries

Will get this in the next pass.

> - Coult not test install, because openafs kmod is not available.

Bug #803  ;-)

> - We prefer to use %defattr(-,root,root,-)

Fixed.

http://www4.ncsu.edu/~jjneely/SPECS/openafs-1.4.11-5.fc11.spec
http://www4.ncsu.edu/~jjneely/SRPMS/openafs-1.4.11-5.fc11.src.rpm


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.